Move types into chainlink-common for LOOPP #299
Conversation
| github.com/jedib0t/go-pretty/v6 v6.4.7 | ||
| github.com/pkg/errors v0.9.1 | ||
| github.com/shopspring/decimal v1.3.1 | ||
| github.com/smartcontractkit/libocr v0.0.0-20230922131214-122accb19ea6 | ||
| github.com/smartcontractkit/libocr v0.0.0-20230925165524-ffa38fe11ef8 |
There was a problem hiding this comment.
libocr is being bumped here as a consequence of adding chainlink-common as a dependency. The only difference in this version of libocr and the previous version, is an update to the README.md.
There was a problem hiding this comment.
is this the libocr version also used in chainlink-core?
There was a problem hiding this comment.
No, core uses a newer version
pkg/v3/types/interfaces.go
Outdated
| // OfInt should return n out of x such that n/x ~ r (ratio) | ||
| OfInt(int) int | ||
| } | ||
| //go:generate mockery --name Ratio --structname MockRatio --srcpkg "github.com/smartcontractkit/chainlink-common/pkg/types/automation" --case underscore --filename ratio.generated.go |
There was a problem hiding this comment.
We're moving the type definitions into common, but automation cares about the mocks, so we're keeping the mocks in this repo (by referencing the chainlink-common package in the generate command)
ferglor
force-pushed
the
feature/AUTO-7266-loopp
branch
3 times, most recently
from
d58b805 to
84658ba
Compare
|
This change will make any automation type change a 3-repo dependency. While that might be needed, it would be good to have an overall design doc to understand the end vision for loops and what components will live where |
ferglor
force-pushed
the
feature/AUTO-7266-loopp
branch
from
6c5aba2 to
98894cb
Compare
Fix import aliases
Update mock Update mocks bump
Use mockery v2.28.1 Move some types back into automation, regenerate mocks Fix tests Update imports Generate Update imports Fix go version Bump to go 1.21 Clean up import aliases
ferglor
force-pushed
the
feature/AUTO-7266-loopp
branch
from
98894cb to
f6cbafc
Compare
ferglor
requested review from
amirylm and
EasterTheBunny
and removed request for
EasterTheBunny and
amirylm
The services created in core will need to come from the new AutomationProvider, as defined in chainlink-common
These services reference types from this repo; rather than make chainlink-common dependent on chainlink-automation, we need to instead move the automation types into the chainlink-common repo
Associated PRs
chainlink: smartcontractkit/chainlink#11631
chainlink-common: smartcontractkit/chainlink-common#297