Remove wrong requirement in exec (#533)

smartcontractkit · Jan 31, 2025 · d5bc1fe · d5bc1fe
1 parent f56c795
commit d5bc1fe
Show file tree

Hide file tree

Showing 2 changed files with 44 additions and 5 deletions.
diff --git a/execute/plugin_functions.go b/execute/plugin_functions.go
@@ -619,10 +619,6 @@ func getConsensusObservation(
 	F int,
 	destChain cciptypes.ChainSelector,
 ) (exectypes.Observation, error) {
-	if len(aos) < F {
-		return exectypes.Observation{}, fmt.Errorf("below F threshold")
-	}
-
 	observedFChains := make(map[cciptypes.ChainSelector][]int)
 	for _, ao := range aos {
 		obs := ao.Observation

diff --git a/execute/plugin_functions_test.go b/execute/plugin_functions_test.go
@@ -761,7 +761,6 @@ func Test_getConsensusObservation(t *testing.T) {
 		want    exectypes.Observation
 		wantErr assert.ErrorAssertionFunc
 	}{
-
 		{
 			name: "empty",
 			args: args{
@@ -795,6 +794,50 @@ func Test_getConsensusObservation(t *testing.T) {
 			},
 			wantErr: assert.NoError,
 		},
+		{
+			name: "consensus when exactly f+1",
+			args: args{
+				observation: []exectypes.Observation{
+					{
+						Nonces: exectypes.NonceObservations{dstChain: {"0x1": 1}},
+						FChain: map[cciptypes.ChainSelector]int{dstChain: 2},
+					},
+					{
+						Nonces: exectypes.NonceObservations{dstChain: {"0x1": 1}},
+						FChain: map[cciptypes.ChainSelector]int{dstChain: 2},
+					},
+					{
+						Nonces: exectypes.NonceObservations{dstChain: {"0x1": 1}},
+						FChain: map[cciptypes.ChainSelector]int{dstChain: 2},
+					},
+				},
+			},
+			want: exectypes.Observation{
+				Nonces: exectypes.NonceObservations{
+					1: {
+						"0x1": 1,
+					},
+				},
+			},
+			wantErr: assert.NoError,
+		},
+		{
+			name: "no consensus when less than f+1",
+			args: args{
+				observation: []exectypes.Observation{
+					{
+						Nonces: exectypes.NonceObservations{dstChain: {"0x1": 1}},
+						FChain: map[cciptypes.ChainSelector]int{dstChain: 2},
+					},
+					{
+						Nonces: exectypes.NonceObservations{dstChain: {"0x1": 1}},
+						FChain: map[cciptypes.ChainSelector]int{dstChain: 2},
+					},
+				},
+			},
+			want:    exectypes.Observation{},
+			wantErr: assert.NoError,
+		},
 		{
 			name: "one ignored consensus observation",
 			args: args{