internal/reader: add bound contract ctor parameter #64
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add a bound contract ctor parameter to the home chain reader constructor to facilitate passing it into the contract reader GetLatestValue calls.
Test Coverage
|
winder
approved these changes
Aug 13, 2024
|
Will get a PR up in CCIP to fix the failing test above |
rstout
approved these changes
Aug 13, 2024
asoliman92
approved these changes
Aug 14, 2024
makramkd
added a commit
to smartcontractkit/ccip
that referenced
this pull request
Aug 14, 2024
## Motivation Bump chainlink-ccip to the version from this PR: smartcontractkit/chainlink-ccip#64 ## Solution Bump and fix the tests.
|
CI green after merging smartcontractkit/ccip#1291, so merging this now. |
makramkd
added a commit
to smartcontractkit/ccip
that referenced
this pull request
Aug 14, 2024
## Motivation Routine bump of chainlink-ccip after the smartcontractkit/chainlink-ccip#64 PR was merged. This has no functional changes, see #1291 for the PR that fixed the integration tests. ## Solution Bump chainlink-ccip.
asoliman92
pushed a commit
to smartcontractkit/chainlink
that referenced
this pull request
Aug 27, 2024
## Motivation Bump chainlink-ccip to the version from this PR: smartcontractkit/chainlink-ccip#64 ## Solution Bump and fix the tests.
asoliman92
pushed a commit
to smartcontractkit/chainlink
that referenced
this pull request
Aug 28, 2024
## Motivation Bump chainlink-ccip to the version from this PR: smartcontractkit/chainlink-ccip#64 ## Solution Bump and fix the tests.
asoliman92
pushed a commit
to smartcontractkit/chainlink
that referenced
this pull request
Aug 28, 2024
## Motivation Bump chainlink-ccip to the version from this PR: smartcontractkit/chainlink-ccip#64 ## Solution Bump and fix the tests.
asoliman92
pushed a commit
to smartcontractkit/chainlink
that referenced
this pull request
Aug 28, 2024
## Motivation Bump chainlink-ccip to the version from this PR: smartcontractkit/chainlink-ccip#64 ## Solution Bump and fix the tests.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a bound contract ctor parameter to the home chain reader constructor to facilitate passing it into the contract reader GetLatestValue calls.
Related PR: smartcontractkit/chainlink-common#603
CCIP PR with integration test fix: smartcontractkit/ccip#1291