add debug logs #697
Open
add debug logs #697
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0xAustinWang
requested review from
winder,
asoliman92,
matYang,
makramkd,
dimkouv,
mateusz-sekara and
0xnogo
|
makramkd
requested changes
Mar 10, 2025
| @@ -585,6 +586,7 @@ func (r *ccipChainReader) GetExpectedNextSequenceNumber( | |||
| sourceChainSelector, r.destChain) | |||
| } | |||
|
|
|||
| r.lggr.Debugw("chain reader returning expected next sequence number", "seqNum", expectedNextSequenceNumber) | |||
There was a problem hiding this comment.
Please create a logger like the other methods,
lggr := logutil.WithContextValues(ctx, r.lggr)So that we have the ocrSeqNr and ocrPhase in the log fields.
| @@ -552,6 +552,7 @@ func (r *ccipChainReader) LatestMsgSeqNum( | |||
| return 0, fmt.Errorf("message invalid msg %v: %w", msg, err) | |||
| } | |||
|
|
|||
| lggr.Debugw("chain reader returning latest message sequence number", "seqNum", msg.Message.Header.SequenceNumber) | |||
There was a problem hiding this comment.
There's a queried latest message from source log above that is Infow but probably should be Debugw. Maybe this can be Infow?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.