pkg/types/core: add Ed25519Signer #1050
Merged
+63
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
krehermann
reviewed
Feb 26, 2025
krehermann
reviewed
Feb 26, 2025
pkg/types/core/keystore.go
Outdated
| func (c *CryptoSigner) Public() crypto.PublicKey { return c.account } | ||
|
|
||
| func (c *CryptoSigner) Sign(rand io.Reader, digest []byte, opts crypto.SignerOpts) (signature []byte, err error) { | ||
| //TODO sanity check rand & opts? |
There was a problem hiding this comment.
are you going to implement something more here?
There was a problem hiding this comment.
It depends what is required to support our usage. I'd like to keep it as simple as possible, and hopefully not have to pass opts over the wire at all. But even in that simplest case, we may want to be strict about validating which opts are passed in so there aren't any surprises.
There was a problem hiding this comment.
Converted to a Ed25519Signer since that is all we need for CSA, and made it stricter here, tolerating only crypto/rand.Reader and crypto.Hash(0) for x509.PureEd25519, and returning a ed25519.PublicKey.
There was a problem hiding this comment.
TLS x509 is the only usage currently, for Mercury/LLO.
jmank88
force-pushed
the
CRE-305-loop-keystore
branch
from
f5a1056 to
0b9672b
Compare
pavel-raykov
previously approved these changes
Feb 28, 2025
jmank88
force-pushed
the
CRE-305-loop-keystore
branch
from
0b9672b to
42aa7a3
Compare
jmank88
changed the title
jmank88
force-pushed
the
CRE-305-loop-keystore
branch
from
42aa7a3 to
6a59f5c
Compare
pavel-raykov
approved these changes
Mar 2, 2025
patrickhuie19
approved these changes
Mar 5, 2025
patrickhuie19
temporarily deployed
to
integration
GitHub Actions
Inactive
patrickhuie19
temporarily deployed
to
integration
GitHub Actions
Inactive
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
smartcontract-it.atlassian.net/browse/CRE-305
Supports: