Make MercuryProvider extend PluginProvider #165
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cedric-cordenier
temporarily deployed
to
integration
GitHub Actions
Inactive
cedric-cordenier
had a problem deploying
to
integration
GitHub Actions
Failure
cedric-cordenier
temporarily deployed
to
integration
GitHub Actions
Inactive
cedric-cordenier
requested review from
jmank88 and
krebernisak
as code owners
|
Can you please open the corresponding |
|
@jmank88 Sure! You can find it here: smartcontractkit/chainlink#10467 |
|
Closing this in favour of #164 which folds these changes in. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We want to replace the
New<Product>Providermethods in the relayer interface with a single, polymorphicNewPluginProvidermethod which extends a common PluginProvider interface exposing the three OCR components required to set up an Oracle.At the moment the MedianProvider and FunctionsProvider both extend this interface, but Mercury does not since it extends the OCR ContractTransmitter with a few additional methods.
This modifies Mercury's interface by splitting this transmitter into two separate components, once which implements
ocrtypes.ContractTransmitterand another which encompasses the additional methods (and implementsmercury.MercuryServerFetcher). This is a largely cosmetic change, since under the hood the transmitter can remain the same struct, just exposed in two different methods.