Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pkg/sqlutil/pg: create package; expand env config #450

Merged
merged 1 commit into from
Jan 21, 2025
Merged

pkg/sqlutil/pg: create package; expand env config #450

merged 1 commit into from
Jan 21, 2025

Conversation

Comment on lines +122 to +123
// Deprecated: Use Driver* constants
type DialectName string
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This type was forcing type conversions and wasn't restricting what could be used, so it is cleaner to use plain string instead. Leaving it here temporarily for compatibility though.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(also it seems to be called 'driver name' everywhere? not sure where the term 'dialect' orginated from)

krehermann
krehermann previously approved these changes Jan 20, 2025
@jmank88 jmank88 merged commit 62443f4 into main Jan 21, 2025
9 of 11 checks passed
@jmank88 jmank88 deleted the pg-db branch January 21, 2025 14:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants