-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
pkg/sqlutil/pg: create package; expand env config #450
Conversation
// Deprecated: Use Driver* constants | ||
type DialectName string |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This type was forcing type conversions and wasn't restricting what could be used, so it is cleaner to use plain string instead. Leaving it here temporarily for compatibility though.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(also it seems to be called 'driver name' everywhere? not sure where the term 'dialect' orginated from)
Supports: