pkg/sqlutil: queryLogger must handle non-positive timeouts and inspect context errors; support custom timing thresholds #530
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
krehermann
previously approved these changes
May 23, 2024
patrickhuie19
previously approved these changes
May 23, 2024
jmank88
changed the title
jmank88
force-pushed
the
query-log-negative
branch
from
a2f000d to
7a332d4
Compare
patrickhuie19
previously approved these changes
May 23, 2024
jmank88
force-pushed
the
query-log-negative
branch
from
7a332d4 to
5072110
Compare
jmank88
changed the title
patrickhuie19
previously approved these changes
May 24, 2024
jmank88
force-pushed
the
query-log-negative
branch
from
5072110 to
8ba5ea9
Compare
jmank88
force-pushed
the
query-log-negative
branch
from
22f4feb to
8d938d2
Compare
| if t == nil { | ||
| return ctx | ||
| } | ||
| return context.WithValue(ctx, ctxKeyLogThresholds{}, *t) |
There was a problem hiding this comment.
Cool! Glad to see us using values in contexts finally, I've wondered why we don't use them more.
Although I hope this won't interfere with any future use of them. If some component needs to have a value attached to a context, but also needs it to have a deadline with custom thresholds, is there a clean way for those to co-exist?
There was a problem hiding this comment.
The context key used here is an unexported type, so nothing outside of this package can use the same key and conflict with it.
jmank88
force-pushed
the
query-log-negative
branch
from
8d938d2 to
3154f0c
Compare
jmank88
force-pushed
the
query-log-negative
branch
from
3154f0c to
e330f6e
Compare
jmank88
changed the title
patrickhuie19
approved these changes
Jun 5, 2024
…ustom timing thresholds
jmank88
force-pushed
the
query-log-negative
branch
from
e330f6e to
46c02a1
Compare
patrickhuie19
approved these changes
Jun 5, 2024
krehermann
approved these changes
Jun 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://smartcontract-it.atlassian.net/browse/BCF-3245
Handle non-positive timeouts gracefully and inspect the context error. In the case of cancelled or unknown error, just return. Only try to calculate how much of the timeout was used for success and explicit
context.DeadlineExceeded.https://smartcontract-it.atlassian.net/browse/BCF-3252
Support customizable thresholds via context values.
Supports: