Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BCF-3139 - Remove TODO comments that are resolved by a related interface impl. PR #572

Merged
merged 1 commit into from
Jun 24, 2024
Merged

BCF-3139 - Remove TODO comments that are resolved by a related interface impl. PR #572

merged 1 commit into from
Jun 24, 2024

Conversation

ilija42
Copy link
Contributor

@ilija42 ilija42 commented Jun 11, 2024 •
edited
Loading

related merged PR : smartcontractkit/chainlink#13356

@ilija42 ilija42 mentioned this pull request Jun 11, 2024
Merged
@ilija42 ilija42 changed the title Remove TODO comments that are resolved by a related interface impl. PR BCF-3139 Remove TODO comments that are resolved by a related interface impl. PR Jun 11, 2024
@ilija42 ilija42 changed the title BCF-3139 Remove TODO comments that are resolved by a related interface impl. PR BCF-3139 - Remove TODO comments that are resolved by a related interface impl. PR Jun 11, 2024
@ilija42 ilija42 force-pushed the BCF-3139-chreader-lp-filter-config branch from 0c67848 to a5807b9 Compare June 24, 2024 10:43
@ilija42 ilija42 requested a review from a team June 24, 2024 13:17
jmank88
jmank88 previously approved these changes Jun 24, 2024
View reviewed changes
krehermann
krehermann previously approved these changes Jun 24, 2024
View reviewed changes
@ilija42 ilija42 dismissed stale reviews from krehermann and jmank88 via a680081 June 24, 2024 13:24
@ilija42 ilija42 force-pushed the BCF-3139-chreader-lp-filter-config branch from a5807b9 to a680081 Compare June 24, 2024 13:24
@ilija42 ilija42 requested review from jmank88 and krehermann June 24, 2024 13:24
@ilija42 ilija42 force-pushed the BCF-3139-chreader-lp-filter-config branch from a680081 to a3f29a7 Compare June 24, 2024 13:26
@ilija42 ilija42 force-pushed the BCF-3139-chreader-lp-filter-config branch from a3f29a7 to 336e718 Compare June 24, 2024 15:31
@ilija42 ilija42 force-pushed the BCF-3139-chreader-lp-filter-config branch from 336e718 to c24551f Compare June 24, 2024 18:50
@ilija42 ilija42 merged commit 90bf017 into main Jun 24, 2024
8 checks passed
@ilija42 ilija42 deleted the BCF-3139-chreader-lp-filter-config branch June 24, 2024 18:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jmank88 jmank88 jmank88 approved these changes

@EasterTheBunny EasterTheBunny EasterTheBunny approved these changes

@vyzaldysanchez vyzaldysanchez vyzaldysanchez approved these changes

@krebernisak krebernisak Awaiting requested review from krebernisak

@krehermann krehermann Awaiting requested review from krehermann

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@ilija42 @jmank88 @EasterTheBunny @vyzaldysanchez @krehermann