Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pkg/types/ccipocr3: add rmn sigs to report #758

Merged
merged 6 commits into from
Sep 10, 2024
Merged

pkg/types/ccipocr3: add rmn sigs to report #758

merged 6 commits into from
Sep 10, 2024

Conversation

makramkd
Copy link
Contributor

@makramkd makramkd commented Sep 10, 2024 •
edited
Loading

Additionally, mark NewCommitPluginReport as deprecated.

Related:

@makramkd
pkg/types/ccipocr3: add rmn sigs to report
34cfa2d 
Additionally, mark NewCommitPluginReport as deprecated.
@makramkd makramkd mentioned this pull request Sep 10, 2024
Merged
@makramkd makramkd marked this pull request as ready for review September 10, 2024 09:26
@makramkd makramkd requested a review from a team as a code owner September 10, 2024 09:26
@makramkd makramkd requested review from EasterTheBunny and removed request for a team September 10, 2024 09:26
makramkd
makramkd commented Sep 10, 2024
View reviewed changes
pkg/types/ccipocr3/plugin_commit_types.go
Comment on lines +23 to 25
// Deprecated: don't use this constructor, just create a CommitPluginReport struct directly.
// Will be removed in a future version once all uses have been replaced.
func NewCommitPluginReport(merkleRoots []MerkleRootChain, tokenPriceUpdates []TokenPrice, gasPriceUpdate []GasPriceChain) CommitPluginReport {
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This function is being deprecated to avoid breaking changes, adding a param would mean a breaking change and a desperate bump across chainlink-ccip and chainlink

dimkouv
dimkouv reviewed Sep 10, 2024
View reviewed changes
Copy link
Collaborator

@dimkouv dimkouv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How do we use FixedDestLaneUpdate fields of the query?

https://github.com/smartcontractkit/chainlink-ccip/blob/12c4fa8dbbadbdc7eca048e6b4fe5ce9d1ce97be/rmn_offchain.proto#L100

Just for offchain/plugin verifications?

@makramkd
Copy link
Contributor Author

makramkd commented Sep 10, 2024 •
edited
Loading

How do we use FixedDestLaneUpdate fields of the query?

The FixedDestLaneUpdate array will have to be equal to the MerkleRoots field in the plugin report. So we have to check that offchain - the full update is not included in the report itself because it'd be redundant, but the sigs are checked against the data in MerkleRoots

We can definitely check the sigs offchain though

@makramkd makramkd requested a review from winder September 10, 2024 11:28
@makramkd makramkd mentioned this pull request Sep 10, 2024
Closed
@makramkd makramkd merged commit 33f9178 into main Sep 10, 2024
10 checks passed
@makramkd makramkd deleted the mk/CCIP-2913/rmnsigs branch September 10, 2024 15:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dimkouv dimkouv dimkouv approved these changes

@winder winder winder approved these changes

@EasterTheBunny EasterTheBunny Awaiting requested review from EasterTheBunny EasterTheBunny is a code owner automatically assigned from smartcontractkit/foundations

@mateusz-sekara mateusz-sekara Awaiting requested review from mateusz-sekara

@asoliman92 asoliman92 Awaiting requested review from asoliman92

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@makramkd @winder @asoliman92 @dimkouv