Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(observability-lib): remove consumers + refactor cmd #964

Merged
merged 2 commits into from
Dec 9, 2024

Conversation

Atrax1
Copy link
Collaborator

@Atrax1 Atrax1 commented Dec 5, 2024

  • Remove consumers from the library
  • Refactor cmd
  • Improve managing notification policies + add associated tests

The reason of moving away consumers is to avoid deploying our grafana resources from chainlink-common CI

@Atrax1 Atrax1 force-pushed the observability-lib-remove-consumers branch from 6b5ee47 to 03eb05e Compare December 5, 2024 11:02
@@ -7,6 +7,10 @@ import (
"github.com/stretchr/testify/require"
)

func Pointer[T any](d T) *T {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we tend to replicate something like this across many of our testing packages.
https://smartcontract-it.atlassian.net/browse/BCF-3448. No need to fix in this PR

@Atrax1 Atrax1 merged commit 182a3d1 into main Dec 9, 2024
10 of 11 checks passed
@Atrax1 Atrax1 deleted the observability-lib-remove-consumers branch December 9, 2024 16:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants