Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename Chain Reader to Contract Reader #418

Merged
merged 3 commits into from
Sep 10, 2024
Merged

Rename Chain Reader to Contract Reader #418

merged 3 commits into from
Sep 10, 2024

Conversation

ilija42
Copy link
Contributor

@ilija42 ilija42 commented Sep 10, 2024

core ref: 0e03149d686002815737e3383dea01d2ab0b3492
core PR
common PR
feeds PR
solana PR
starknet PR

silaslenihan
silaslenihan previously approved these changes Sep 10, 2024
Farber98
Farber98 previously approved these changes Sep 10, 2024
Copy link

@Farber98 Farber98 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

changes look good but integration tests are failing. seems dependencies issues

@Farber98 Farber98 self-requested a review September 10, 2024 13:53
@Farber98 Farber98 dismissed their stale review September 10, 2024 13:53

changes look good but integration tests are failing. seems dependencies issues

jmank88
jmank88 previously approved these changes Sep 10, 2024
Farber98
Farber98 previously approved these changes Sep 10, 2024
@cl-sonarqube-production
Copy link

Copy link

@silaslenihan silaslenihan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ilija42 ilija42 merged commit 638ba8a into develop Sep 10, 2024
15 of 16 checks passed
@ilija42 ilija42 deleted the BCF-3380-rename-CR branch September 10, 2024 21:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants