Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Head Tracker Finality Violation Detection #28

Open
wants to merge 16 commits into
base: main
Choose a base branch
from
Open

Head Tracker Finality Violation Detection #28

wants to merge 16 commits into from

Conversation

DylanTinianov
Copy link
Contributor

@DylanTinianov DylanTinianov commented Feb 13, 2025 •
edited
Loading

Description

Ticket: https://smartcontract-it.atlassian.net/browse/BCFR-1107
Added finality violation detection to head tracker.

Tests PR

smartcontractkit/chainlink-integrations#11

@DylanTinianov DylanTinianov requested a review from a team as a code owner February 13, 2025 18:40
@DylanTinianov DylanTinianov self-assigned this Feb 13, 2025
@DylanTinianov DylanTinianov marked this pull request as draft February 13, 2025 19:54
@DylanTinianov DylanTinianov changed the title Verify finalized block hashes and handle finality violation errors Verify finalized block hashes and return finality violation errors Feb 13, 2025
@DylanTinianov DylanTinianov changed the title Verify finalized block hashes and return finality violation errors Verify Finalized Block Hashes and Return Finality Violation Errors Feb 13, 2025
Farber98
Farber98 previously approved these changes Feb 14, 2025
View reviewed changes
Copy link

@Farber98 Farber98 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not an expert here, but I believe it meets both ticket requirements

@DylanTinianov DylanTinianov mentioned this pull request Feb 19, 2025
Open
@DylanTinianov DylanTinianov marked this pull request as ready for review February 19, 2025 16:40
dhaidashenko
dhaidashenko reviewed Feb 19, 2025
View reviewed changes
@DylanTinianov DylanTinianov changed the title Verify Finalized Block Hashes and Return Finality Violation Errors Head Tracker Finality Validation Feb 19, 2025
@DylanTinianov DylanTinianov changed the title Head Tracker Finality Validation Add Finality Validation to Head Tracker Feb 19, 2025
@DylanTinianov DylanTinianov changed the title Add Finality Validation to Head Tracker Head Tracker Finality Validation Feb 19, 2025
dhaidashenko
dhaidashenko reviewed Feb 20, 2025
View reviewed changes
@DylanTinianov DylanTinianov changed the title Head Tracker Finality Validation Head Tracker Finality Violation Detection Feb 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Farber98 Farber98 Awaiting requested review from Farber98

@dhaidashenko dhaidashenko Awaiting requested review from dhaidashenko

At least 2 approving reviews are required to merge this pull request.

Assignees

@DylanTinianov DylanTinianov

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@DylanTinianov @dhaidashenko @Farber98