Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TOML migration #572

Merged
merged 9 commits into from
Feb 7, 2024
Merged

TOML migration #572

merged 9 commits into from
Feb 7, 2024

Conversation

smickovskid
Copy link
Contributor

  • TOML migration

@smickovskid smickovskid marked this pull request as draft February 7, 2024 09:50
@aalu1418 aalu1418 mentioned this pull request Feb 7, 2024
Closed
@aalu1418 aalu1418 mentioned this pull request Feb 7, 2024
Merged
@cl-sonarqube-production
Copy link

SonarQube Quality Gate

Quality Gate failed

Failed condition 21.1% 21.12% Duplicated Lines (%) on New Code (is greater than 3%)

See analysis details on SonarQube

aalu1418
aalu1418 approved these changes Feb 7, 2024
View reviewed changes
Copy link
Collaborator

@aalu1418 aalu1418 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approving + overriding merge

requires downstream changes in core to pass CI:

@aalu1418 aalu1418 marked this pull request as ready for review February 7, 2024 18:23
@aalu1418 aalu1418 merged commit 414a666 into develop Feb 7, 2024
22 of 24 checks passed
@aalu1418 aalu1418 deleted the TT-802 branch February 7, 2024 18:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aalu1418 aalu1418 aalu1418 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@smickovskid @aalu1418