Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SOM: balance monitoring #654

Merged
merged 12 commits into from
Apr 16, 2024
Merged

SOM: balance monitoring #654

merged 12 commits into from
Apr 16, 2024

Conversation

aalu1418
Copy link
Collaborator

@aalu1418 aalu1418 commented Apr 3, 2024 •
edited
Loading

https://smartcontract-it.atlassian.net/browse/BCI-2900

Primary additions are:

  • source_node_balances.go
  • metrics/nodebalances.go
  • exporters/nodebalances.go
    everything else is reorganization

@aalu1418 aalu1418 force-pushed the som-balance-monitoring branch from 70d2ca6 to 404830b Compare April 15, 2024 16:38
@aalu1418 aalu1418 marked this pull request as ready for review April 15, 2024 22:39
@aalu1418 aalu1418 requested review from a team as code owners April 15, 2024 22:39
@aalu1418 aalu1418 requested review from topliceanu and pedrovsg April 15, 2024 22:39
topliceanu
topliceanu approved these changes Apr 16, 2024
View reviewed changes
Copy link
Contributor

@topliceanu topliceanu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks alright

pkg/monitoring/source_feed_balances.go Show resolved Hide resolved
@aalu1418 aalu1418 enabled auto-merge (squash) April 16, 2024 13:13
@cl-sonarqube-production
Copy link

Quality Gate passed Quality Gate passed

Issues
0 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
83.7% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube

@aalu1418 aalu1418 merged commit c808024 into develop Apr 16, 2024
25 checks passed
@aalu1418 aalu1418 deleted the som-balance-monitoring branch April 16, 2024 13:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@topliceanu topliceanu topliceanu approved these changes

@pedrovsg pedrovsg Awaiting requested review from pedrovsg

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@aalu1418 @topliceanu