Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use Docker Run Instead of GHA container image for node 16 shutdown #701

Closed
wants to merge 12 commits into from
Closed

Use Docker Run Instead of GHA container image for node 16 shutdown #701

wants to merge 12 commits into from

Conversation

tateexon
Copy link
Contributor

@tateexon tateexon commented May 9, 2024 •
edited
Loading

This temporarily gets around node 16 shutdown causing this to break starting 5/13/2024
If the update to the backpackapp/build is done before Monday then this can be closed and or reverted.

tateexon added 2 commits May 9, 2024 11:25
@tateexon
Use a docker run command to build contracts
34e5fdf 
This temporarily gets around node issues for building contracts
@tateexon
update checkout version
52a7d39
@tateexon tateexon force-pushed the tmp_node_workflow_fix branch from 004c598 to 701e673 Compare May 9, 2024 20:02
@tateexon tateexon force-pushed the tmp_node_workflow_fix branch from 701e673 to 224bd4e Compare May 9, 2024 20:16
@cl-sonarqube-production
Copy link

Quality Gate passed Quality Gate passed

Issues
0 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarQube

@tateexon tateexon changed the title Use a docker run command to build contracts Use Docker Run Instead of GHA container image for node 16 shutdown May 9, 2024
@tateexon tateexon marked this pull request as ready for review May 9, 2024 20:33
@tateexon tateexon requested a review from a team as a code owner May 9, 2024 20:33
erikburt
erikburt approved these changes May 10, 2024
View reviewed changes
Copy link
Contributor

@erikburt erikburt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me - I'm going to try and pull this into #697 and test everything w/ node20 actions.

@erikburt erikburt mentioned this pull request May 10, 2024
Merged
@erikburt
Copy link
Contributor

Closing in favour of #702

@erikburt erikburt closed this May 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@erikburt erikburt erikburt approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tateexon @erikburt