Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BCI-2848] Added TOML support, moved tests to gauntlet, bumped deps #705
[BCI-2848] Added TOML support, moved tests to gauntlet, bumped deps #705
Changes from 45 commits
2182c93
01cc5ac
fed26c2
39398a2
4f91c1d
d2eb2c1
badfce2
7644097
736210d
568aea8
f555ba8
8179186
89f16d5
e733712
c21d0e6
2cf4134
d238e26
06d61f4
292b165
8cf5b1f
ddfb378
3a38564
b036884
7796d89
1ef70ff
63537f0
2176e4b
f27ee5e
265f9d5
1425062
93205d5
443e504
b7ba833
7b5252d
ca665e6
88b9629
1517a09
e5be900
e62e035
3c5d895
129d588
a81266e
8a66300
6835833
7dd922f
ff1204a
83239d1
f7ae48c
ff47af5
539f1d1
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How is
download_contract_artifacts_path
used?Interested as we're currently working on contract distribution via Nix/Manifest with G++.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i think this is for previously compiled contract components as part of the tests
chainlink-solana/.github/workflows/e2e_custom_cl.yml
Line 50 in 1549341
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Correct, the CTF action takes in an optional argument and the location of an artifact so it downloads it to the workspace
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Again, we should start using Nix across the board vs. asdf
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How do we run soak tests?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We don't directly have it atm as in kicking it off as a soak, but it is indirectly possible by setting a long TTL and rounds. I need to create a followup task to specifically create a soak trigger.