fix: remove default pass on linters #711
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
aalu1418
commented
May 20, 2024
•
aalu1418
commented
- relayer
- integration-tests
aalu1418
force-pushed
the
fix/enable-linters
branch
from
4f396b8 to
439088f
Compare
aalu1418
force-pushed
the
fix/enable-linters
branch
from
439088f to
2c383f1
Compare
aalu1418
force-pushed
the
fix/enable-linters
branch
from
72b308a to
33641eb
Compare
aalu1418
force-pushed
the
fix/enable-linters
branch
from
33641eb to
43c3c57
Compare
aalu1418
force-pushed
the
fix/enable-linters
branch
from
43c3c57 to
d08ed05
Compare
|
jmank88
reviewed
May 20, 2024
| @@ -3,7 +3,7 @@ | |||
| pkgs.mkShell { | |||
| nativeBuildInputs = with pkgs; [ | |||
| (rust-bin.stable.latest.default.override { extensions = ["rust-src"]; }) | |||
| lld_10 | |||
| # lld_10 | |||
There was a problem hiding this comment.
my understanding it's a toolchain but @archseer also has it disabled in a PR that's updating even more dependencies https://github.com/smartcontractkit/chainlink-solana/pull/588/files#diff-e53dfbfffe62ae3c0b411b3938ccffa9fb6a2ecc565f55785ef8daa756631a6b
jmank88
approved these changes
May 20, 2024
aalu1418
added a commit
that referenced
this pull request
May 21, 2024
* fix: remove default pass on linters (#711) * remove default pass on integration tests + relayer * upgrade to go1.21.6 * fix relay linter issues * fix e2e test linter * fix e2e tests * linter fixes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.