fix: handle compute unit + lookup tables, and improve flaky tests #965
Conversation
aalu1418
force-pushed
the
fix/handle-compute-unit-and-lookup-tables
branch
from
1654290 to
e0678bc
Compare
aalu1418
force-pushed
the
fix/handle-compute-unit-and-lookup-tables
branch
from
e0678bc to
bd6a260
Compare
aalu1418
requested review from
agusaldasoro,
toblich,
jadepark-dev and
amit-momin
|
|
|
||
| // lookup table addresses are indexed after the tx.Message.AccountKeys | ||
| // higher indices must be increased | ||
| // https://github.com/gagliardetto/solana-go/blob/da2193071f56059aa35010a239cece016c4e827f/transaction.go#L440 |
There was a problem hiding this comment.
If solana-go lib does the same, why do we need a wrapper here? Can not we use just the library instead? I'm thinking that we need to avoid having any other bug on our side in the future
There was a problem hiding this comment.
it doesn't do the exact same thing - this comment is mostly just pointing out that lookup table addresses are indexes that are larger than the normal message.accountkeys array
solana-go requires a user to predeclare all instructions and then compile things together
our utility allows modification of an compiled transaction to include compute budget instructions
* fix: handle compute unit + lookup tables, and improve flaky tests * more complex: multiple instructions + multiple indices
* fix: handle compute unit + lookup tables, and improve flaky tests * more complex: multiple instructions + multiple indices
Description
GetBlocksslot generation != block generation so it can lag behind - increase timeout to reduce flakiness