Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BCF-2700: move chain and config from core #329

Merged
merged 1 commit into from
Oct 23, 2023
Merged

BCF-2700: move chain and config from core #329

merged 1 commit into from
Oct 23, 2023

Conversation

jmank88
Copy link
Contributor

@jmank88 jmank88 commented Oct 18, 2023 •
edited
Loading

@jmank88 jmank88 mentioned this pull request Oct 18, 2023
Merged
1 task
@jmank88 jmank88 changed the title move chain and config from core BCF-2700: move chain and config from core Oct 18, 2023
@jmank88 jmank88 force-pushed the BCF-2700-mv-starknet-chain branch from f9a67ee to 29d532b Compare October 18, 2023 13:07
@jmank88 jmank88 temporarily deployed to integration October 18, 2023 13:08 — with GitHub Actions Inactive
@jmank88 jmank88 temporarily deployed to integration October 18, 2023 13:08 — with GitHub Actions Inactive
@jmank88 jmank88 temporarily deployed to integration October 18, 2023 13:48 — with GitHub Actions Inactive
@jmank88 jmank88 temporarily deployed to integration October 18, 2023 13:48 — with GitHub Actions Inactive
@jmank88 jmank88 temporarily deployed to integration October 18, 2023 14:27 — with GitHub Actions Inactive
@jmank88 jmank88 temporarily deployed to integration October 18, 2023 14:27 — with GitHub Actions Inactive
@jmank88 jmank88 force-pushed the BCF-2700-mv-starknet-chain branch from f41f461 to f0c7881 Compare October 19, 2023 13:18
@jmank88 jmank88 temporarily deployed to integration October 19, 2023 13:18 — with GitHub Actions Inactive
@jmank88 jmank88 temporarily deployed to integration October 19, 2023 13:18 — with GitHub Actions Inactive
@jmank88 jmank88 force-pushed the BCF-2700-mv-starknet-chain branch from f0c7881 to bdb1876 Compare October 20, 2023 23:10
@jmank88 jmank88 temporarily deployed to integration October 20, 2023 23:10 — with GitHub Actions Inactive
@jmank88 jmank88 temporarily deployed to integration October 20, 2023 23:10 — with GitHub Actions Inactive
@jmank88 jmank88 temporarily deployed to integration October 23, 2023 21:19 — with GitHub Actions Inactive
@jmank88 jmank88 temporarily deployed to integration October 23, 2023 21:19 — with GitHub Actions Inactive
@jmank88 jmank88 force-pushed the BCF-2700-mv-starknet-chain branch from 51afa03 to 0ab6cc6 Compare October 23, 2023 21:39
@jmank88 jmank88 temporarily deployed to integration October 23, 2023 21:39 — with GitHub Actions Inactive
@jmank88 jmank88 temporarily deployed to integration October 23, 2023 21:39 — with GitHub Actions Inactive
@jmank88 jmank88 marked this pull request as ready for review October 23, 2023 21:49
@jmank88 jmank88 requested a review from krehermann October 23, 2023 21:51
@jmank88 jmank88 force-pushed the BCF-2700-mv-starknet-chain branch from 0ab6cc6 to 23fab03 Compare October 23, 2023 21:56
@jmank88 jmank88 temporarily deployed to integration October 23, 2023 21:56 — with GitHub Actions Inactive
@jmank88 jmank88 temporarily deployed to integration October 23, 2023 21:56 — with GitHub Actions Inactive
@jmank88 jmank88 force-pushed the BCF-2700-mv-starknet-chain branch from 23fab03 to 27f2d96 Compare October 23, 2023 22:13
@jmank88 jmank88 temporarily deployed to integration October 23, 2023 22:13 — with GitHub Actions Inactive
patrickhuie19
patrickhuie19 previously approved these changes Oct 23, 2023
View reviewed changes
@jmank88
move chain and config from core
c51f611 
bump go version on nix + nixpkgs

bump golangci-lint

make golangci-lint build use go1.21
@jmank88 jmank88 force-pushed the BCF-2700-mv-starknet-chain branch from 27f2d96 to c51f611 Compare October 23, 2023 22:22
@jmank88 jmank88 temporarily deployed to integration October 23, 2023 22:22 — with GitHub Actions Inactive
@jmank88 jmank88 temporarily deployed to integration October 23, 2023 22:22 — with GitHub Actions Inactive
@jmank88 jmank88 requested a review from patrickhuie19 October 23, 2023 22:35
@cl-sonarqube-production
Copy link

SonarQube Quality Gate

Quality Gate failed

Failed condition 0.0% 0.0% Coverage on New Code (is less than 75%)

See analysis details on SonarQube

@jmank88 jmank88 merged commit 9be0aa9 into develop Oct 23, 2023
12 of 19 checks passed
@jmank88 jmank88 deleted the BCF-2700-mv-starknet-chain branch October 23, 2023 22:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@patrickhuie19 patrickhuie19 patrickhuie19 approved these changes

@krehermann krehermann krehermann approved these changes

@archseer archseer Awaiting requested review from archseer

@smickovskid smickovskid Awaiting requested review from smickovskid

@aalu1418 aalu1418 Awaiting requested review from aalu1418

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jmank88 @krehermann @patrickhuie19