Fix ci #356
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -125,7 +125,9 @@ jobs: | |
| TEST_DURATION: 15m | ||
| NODE_COUNT: 5 | ||
| CHAINLINK_IMAGE: ${{ secrets.QA_AWS_ACCOUNT_NUMBER }}.dkr.ecr.${{ secrets.QA_AWS_REGION }}.amazonaws.com/chainlink | ||
| CHAINLINK_VERSION: starknet.${{ github.sha }} | ||
| INTERNAL_DOCKER_REPO: ${{ secrets.QA_AWS_ACCOUNT_NUMBER }}.dkr.ecr.${{ secrets.QA_AWS_REGION }}.amazonaws.com | ||
| scarb_version: "v2.5.4" | ||
|
There was a problem hiding this comment. +1 to using the install-cairo action, then we don't need |
||
| permissions: | ||
| checks: write | ||
| pull-requests: write | ||
|
|
@@ -147,9 +149,36 @@ jobs: | |
| uses: cachix/install-nix-action@29bd9290ef037a3ecbdafe83cbd2185e9dd0fa0a # v20 | ||
| with: | ||
| nix_path: nixpkgs=channel:nixos-unstable | ||
| - name: Setup Scarb for Linux | ||
| id: install-scarb | ||
| shell: bash | ||
| run: | | ||
| wget https://github.com/software-mansion/scarb/releases/download/${{ env.scarb_version }}/scarb-${{ env.scarb_version }}-x86_64-unknown-linux-musl.tar.gz | ||
| tar -xvzf scarb-${{ env.scarb_version }}-x86_64-unknown-linux-musl.tar.gz | ||
| mv -vf scarb-${{ env.scarb_version }}-x86_64-unknown-linux-musl scarb-build | ||
| echo "$GITHUB_WORKSPACE/scarb-build/bin" >> $GITHUB_PATH | ||
|
There was a problem hiding this comment. Why not just use the action we use on all the other workflows chainlink-starknet/.github/workflows/contracts.yml Lines 41 to 42 in 57cedea |
||
| - name: Build contracts | ||
| run: | | ||
| cd contracts && scarb --profile release build | ||
| - name: Generate config overrides | ||
| run: | # https://github.com/smartcontractkit/chainlink-testing-framework/blob/main/config/README.md | ||
| cat << EOF > config.toml | ||
| [ChainlinkImage] | ||
| image="${{ env.CHAINLINK_IMAGE }}" | ||
| version="${{ env.CHAINLINK_VERSION }}" | ||
| [Network] | ||
| selected_networks=["SIMULATED"] | ||
| EOF | ||
| # shellcheck disable=SC2002 | ||
| BASE64_CONFIG_OVERRIDE=$(cat config.toml | base64 -w 0) | ||
| # shellcheck disable=SC2086 | ||
| echo ::add-mask::$BASE64_CONFIG_OVERRIDE | ||
| # shellcheck disable=SC2086 | ||
| echo "BASE64_CONFIG_OVERRIDE=$BASE64_CONFIG_OVERRIDE" >> $GITHUB_ENV | ||
| - name: Run Tests ${{ matrix.image.name }} | ||
| uses: smartcontractkit/chainlink-github-actions/chainlink-testing-framework/run-tests@ea889b3133bd7f16ab19ba4ba130de5d9162c669 # v2.3.4 | ||
| with: | ||
| aws_registries: ${{ secrets.QA_AWS_ACCOUNT_NUMBER }} | ||
| test_command_to_run: nix develop -c helm repo update && make test-integration-smoke-ci | ||
| test_download_vendor_packages_command: cd integration-tests && nix develop -c go mod download | ||
| cl_repo: ${{ env.CL_ECR }} | ||
|
|
@@ -159,4 +188,4 @@ jobs: | |
| QA_AWS_REGION: ${{ secrets.QA_AWS_REGION }} | ||
| QA_AWS_ROLE_TO_ASSUME: ${{ secrets.QA_AWS_ROLE_TO_ASSUME }} | ||
| QA_KUBECONFIG: ${{ secrets.QA_KUBECONFIG }} | ||
| artifacts_location: /home/runner/work/chainlink-starknet/chainlink-starknet/integration-tests/smoke/logs | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -166,3 +166,4 @@ ztarrepo.tar.gz | |
| eslint-report.json | ||
| .run.id | ||
| .local-mock-server | ||
| overrides.toml | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
There was a problem hiding this comment. This is related to the testconfig and TOML changes, that is how the logic knows where to look for the toml configurations. |
Empty file.
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is the matrix suffix not necessary now? the push_tag on L69 still push with a
matrix.image.tag-suffix?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes we need to maintain both if we want to run long running soak tests, if we only use docker there is no reliable way to run our tests for a longer period of time.