-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
NONEVM-629: Link Token Changes #535
Conversation
@@ -0,0 +1,79 @@ | |||
use starknet::ContractAddress; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
doing a diff between v2/erc667.cairo
and v1/erc667.cairo
will make the changes more apparent
Quality Gate failedFailed conditions |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
have limited context but based off the pr description this looks fine to me 👍
Based off of the design here: https://docs.google.com/document/d/1VxcXMJtfqh2Sej6NruQ2KtCuNz8t07AKOaaXsyZY2LQ/edit?usp=sharing
For reviewing, doing a diff between v2/erc667.cairo and v1/erc667.cairo will make the changes more apparent
Likewise, do a diff between v2/LinkToken.cairo and v1/LinkToken.cairo
legacy gauntlet is not needed to change because the new token will only be used on G++
Creates version 2 of the link token, which