Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NONEVM-629: Link Token Changes #535

Merged
merged 3 commits into from
Oct 24, 2024

Conversation

augustbleeds
Copy link
Collaborator

@augustbleeds augustbleeds commented Oct 1, 2024

Based off of the design here: https://docs.google.com/document/d/1VxcXMJtfqh2Sej6NruQ2KtCuNz8t07AKOaaXsyZY2LQ/edit?usp=sharing

For reviewing, doing a diff between v2/erc667.cairo and v1/erc667.cairo will make the changes more apparent
Likewise, do a diff between v2/LinkToken.cairo and v1/LinkToken.cairo

  • contract changes

legacy gauntlet is not needed to change because the new token will only be used on G++

Creates version 2 of the link token, which

  • alters the LINK token constructor to play nicely with the bridge
  • adds a set_minter function
  • changes ERC677 to use SRC-5 instead of ERC-165
  • adds an ERC677ReceiverComponent

@@ -0,0 +1,79 @@
use starknet::ContractAddress;
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

doing a diff between v2/erc667.cairo and v1/erc667.cairo will make the changes more apparent

@cl-sonarqube-production
Copy link

Quality Gate failed Quality Gate failed

Failed conditions
0.0% Coverage on New Code (required ≥ 75%)

See analysis details on SonarQube

Copy link
Contributor

@calvwang9 calvwang9 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

have limited context but based off the pr description this looks fine to me 👍

@augustbleeds augustbleeds merged commit bfc10fe into develop Oct 24, 2024
22 of 23 checks passed
@augustbleeds augustbleeds deleted the augustus.NONEVM-629.modify-token branch October 24, 2024 13:18
chray-zhang pushed a commit that referenced this pull request Nov 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants