Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

disable proxy access check by default #547

Closed

Conversation

augustbleeds
Copy link
Collaborator

Disables the access check for proxy contracts, so that by default anyone can read from the proxy.

however the access check is left enabled (by default) for aggregator contracts and the stand alone access controller contract

augustbleeds and others added 30 commits March 22, 2024 01:35
* debug logs

* publickey is for nonce manager, not contract address

* add skip validate to estimate

* change tag to pending

* make deep copy in txstore

* deep copy fix

* set x-apikey option for juno rpc

* fix bug

* add api key in few places

* fix debug err

* log

* tidy up logging

* remove nonce tracking from txstore

* clean up deep copy

* remove test
* adjust token amount + add exp timer

* add back skip_validate flag

* modify config
@cl-sonarqube-production
Copy link

Quality Gate passed Quality Gate passed

Issues
0 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarQube

Michipulatos
Michipulatos previously approved these changes Nov 8, 2024
@augustbleeds augustbleeds changed the base branch from develop to augustus.compile-bump-cairo November 14, 2024 14:01
@augustbleeds augustbleeds changed the base branch from augustus.compile-bump-cairo to develop November 14, 2024 14:02
@augustbleeds augustbleeds dismissed Michipulatos’s stale review November 14, 2024 14:02

The base branch was changed.

@augustbleeds augustbleeds requested a review from a team as a code owner November 14, 2024 14:02
@chray-zhang chray-zhang force-pushed the augustus.NONEVM-333.disable-proxy-access-check branch from b9cccdc to d6eb791 Compare November 25, 2024 21:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.