Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bump juno v0.12.4; bump starknet.go v0.7.2 #555

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from
Open

Conversation

chray-zhang
Copy link
Contributor

No description provided.

@jmank88 jmank88 changed the title bump starknet.go v0.7.2; juno v0.12.0 bump juno v0.12.4 Nov 26, 2024
@jmank88 jmank88 changed the title bump juno v0.12.4 bump juno v0.12.4; bump starknet.go v0.7.2 Nov 26, 2024
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These had incompatibilities, but they were unused.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This type was renamed

@jmank88
Copy link
Contributor

jmank88 commented Nov 26, 2024

The txm is constructing a InvokeTxnV3 but AddInvokeTransaction now expects a rpc.BroadcastInvokeTxnType

@cl-sonarqube-production
Copy link

Quality Gate failed Quality Gate failed

Failed conditions
0.0% Coverage on New Code (required ≥ 75%)

See analysis details on SonarQube

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants