Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Audit Fixes #573

Merged
merged 24 commits into from
Jan 10, 2025
Merged

Audit Fixes #573

Changes from 1 commit
Commits
Show all changes
24 commits
Select commit Hold shift + click to select a range
c6b6a04
stop using deprecated alexandria keccak + remove unused vars
augustbleeds Dec 11, 2024
84cc3cd
address code quality issues
augustbleeds Dec 11, 2024
36f94ab
add zero check for token
augustbleeds Dec 12, 2024
ff8e41d
update alexandria and use its functions
augustbleeds Dec 12, 2024
313ec2a
use oz upgradeable
augustbleeds Dec 13, 2024
40d4df5
add 0 check for link token v2
augustbleeds Dec 13, 2024
e6437f5
conditionally emit event
augustbleeds Dec 29, 2024
65c77ba
update oz, alexandria, scarb/cairo
augustbleeds Dec 30, 2024
1365a6c
update ci/cd for 2.9.2
augustbleeds Dec 30, 2024
a424843
lint
augustbleeds Dec 30, 2024
67fa3a4
fix github actions to hash
augustbleeds Dec 30, 2024
dfc1e6b
fix issue 10 and install zizmor nix shell
augustbleeds Dec 30, 2024
5a893f2
lint examples
augustbleeds Dec 30, 2024
d7da88a
update golangci
augustbleeds Dec 30, 2024
a383ccd
fix 11 and add static analysis workflow
augustbleeds Dec 30, 2024
f9fe424
lint go
augustbleeds Dec 30, 2024
e369833
rename job
augustbleeds Dec 30, 2024
8b5e90d
fix typo
augustbleeds Dec 30, 2024
4159d85
add code comment references
augustbleeds Dec 30, 2024
dec8dd6
comments
augustbleeds Dec 30, 2024
85c0038
code comment
augustbleeds Dec 30, 2024
b174a97
fix lint
augustbleeds Dec 30, 2024
1d0c792
fix ci/cd
augustbleeds Jan 7, 2025
baa3c6e
update zizmor
augustbleeds Jan 10, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fix typo
  • Loading branch information
@augustbleeds
augustbleeds committed Dec 30, 2024
commit 8b5e90db0b64d13d940409f212530556e8caad32
4 changes: 2 additions & 2 deletions relayer/pkg/chainlink/ocr2/medianreport/onchainconfig.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,8 +52,8 @@ func (codec OnchainConfigCodec) Decode(ctx context.Context, b []byte) (median.On
minVal := felts[1]
maxVal := felts[2]

if !(min.Cmp(max) <= 0) {
return median.OnchainConfig{}, fmt.Errorf("OnchainConfig min (%v) should not be greater than max(%v)", min, max)
if !(minVal.Cmp(maxVal) <= 0) {
return median.OnchainConfig{}, fmt.Errorf("OnchainConfig min (%v) should not be greater than max(%v)", minVal, maxVal)
}

return median.OnchainConfig{Min: minVal, Max: maxVal}, nil
Expand Down
Loading