Propagate pre-commit errors when running go commands (#933)

.githooks/go-lint

@@ -1,14 +1,13 @@
 #!/bin/bash
 
 # Find all 'go.mod' files, get their directories, and run 'go mod tidy'
-# shellcheck disable=SC2016
-find "./" -type f -name 'go.mod' -print0 | xargs -0 -I{} bash -c '
-    directory=$(dirname "{}")
+find "./" -type f -name 'go.mod' -print0 | while IFS= read -r -d $'\0' file; do
+    directory=$(dirname "$file")
     cd "$directory" || exit 1
 
     # Run linter and capture exit status
-    golangci-lint run  > /dev/null
-    local linting_result=$?
+    golangci-lint run > /dev/null
+    linting_result=$?
 
     # Check linting result
     if [[ $linting_result -ne 0 ]]; then
@@ -18,4 +17,5 @@ find "./" -type f -name 'go.mod' -print0 | xargs -0 -I{} bash -c '
     else
         echo -e "Executing linters in $directory... \e[32mOK!\e[0m\n"
     fi
-'
+    cd - || exit 1
+done

.githooks/go-mod-tidy

@@ -3,13 +3,13 @@
 set -e
 
 # Find all 'go.mod' files, get their directories, and run 'go mod tidy'
-# shellcheck disable=SC2016
-find "./" -type f -name 'go.mod' -print0 | xargs -0 -I{} bash -c '
-    dir=$(dirname "{}")
+find "./" -type f -name 'go.mod' -print0 | while IFS= read -r -d $'\0' file; do
+    dir=$(dirname "$file")
     echo "Executing cd \"$dir\" && go mod tidy"
     cd "$dir"
     go mod tidy
-'
+    cd -
+done
 # pre-commit stashes changes before running the hooks so we can use git to check for changes here
 # Run git diff and capture output
 output=$(git diff --stat)

.githooks/go-test-build

@@ -3,10 +3,10 @@
 set -e
 
 # Find all 'go.mod' files, get their directories, and run an empty 'go test' in them to compile the tests.
-# shellcheck disable=SC2016
-find "./" -type f -name 'go.mod' -print0 | xargs -0 -I{} bash -c '
-    dir=$(dirname "{}")
+find "./" -type f -name 'go.mod' -print0 | while IFS= read -r -d $'\0' file; do
+    dir=$(dirname "$file")
     echo "Executing cd \"$dir\" && go test -run=^# ./..."
     cd "$dir"
     go test -run=^# ./...
-'
+    cd -
+done