Ship 3979 remove ws validation seth #1316
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidcauchi
temporarily deployed
to
integration
GitHub Actions
Inactive
davidcauchi
had a problem deploying
to
integration
GitHub Actions
Failure
davidcauchi
had a problem deploying
to
integration
GitHub Actions
Failure
|
gheorghestrimtu
approved these changes
Nov 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add option to force SETH to initialize with HTTP instead of the default WS.
Intention is to avoid passing RPC urls with urls_secret and instead only set
force_http=trueBelow is a summarization created by an LLM (gpt-4-0125-preview). Be mindful of hallucinations and verify accuracy.
Why
The changes introduce configuration support for HTTP connections, improve readability, and ensure consistency in timeout settings across various network configurations. By allowing HTTP connections, users have more flexibility in how they interact with blockchain networks.
What
force_httpto true, enhancing the guidance for users on connection options.ForceHTTPboolean field in theConfigstruct to support HTTP connections, providing users with the ability to choose their preferred protocol.force_httpconfiguration option, enabling users to configure their connection protocol preference.dial_timeoutassignment across all network configurations to improve readability and maintain consistency.