[TT-1934] event hash collision

[Tofel]

After changing Seth logic to debug event using all ABIs I’ve noticed an intermitently failing Seth smoke test, which turned out to be caused by event signature collision. Two contracts have events with the same name and parameters, but one of them has the last parameter non-indexed. And when that contract’s ABI is selected for decoding, then the test fails.

Comparing signature of the whole event is complicated due to various data types, so I will apply a simpler fix:

if we know what contract is at given address, we know its ABI and we don’t need to iterate overall ABIs

if we don’t then we will iterate over all, but apart from signature also check whether number of indexed parameter matches the log (that’s an easy check)

---

Below is a summarization created by an LLM (gpt-4-0125-preview). Be mindful of hallucinations and verify accuracy.

Why

The changes improve contract log decoding by optimizing the event matching process and fixing minor issues in function parameters and comments. These changes aim to enhance performance, accuracy in event log decoding, and clarity in the codebase.

What

• seth/client.go
  • Added reflect package import for deep equality checks.
  • Refactored decodeContractLogs to use a precomputed map (sigMap) of event signatures to their possible events and ABIs, improving efficiency by avoiding redundant ABI iterations.
  • Introduced buildEventSignatureMap function to create a signature to event and ABI mapping, facilitating faster event log decoding.
  • Improved logging messages for clarity and debuggability.
  • Added checks for logs with no topics and mismatching indexed parameters, ensuring only logs with matching event signatures and correct indexed parameter counts are processed.
  • Implemented logic to handle known contract ABIs directly, reducing unnecessary ABI comparisons.
• seth/contract_map.go
  • Fixed parameter name in GetContractAddress to accurately reflect its purpose, enhancing code readability and maintainability.
• tools/breakingchanges/cmd/main.go
  • Corrected a typo and clarified a comment in getLatestTag to improve code documentation and readability.

[cl-sonarqube-production]

Quality Gate passed

Issues
2 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarQube