WASP v1.50.5 changeset #1548
Merged
WASP v1.50.5 changeset #1548
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
skudasov
approved these changes
Jan 10, 2025
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Below is a summarization created by an LLM (gpt-4-0125-preview). Be mindful of hallucinations and verify accuracy.
Why
The changes improve
BenchSpy, a performance comparison tool, by adding threshold validation, ensuring reports are not nil, and enhancing readability when there's an infinite metric change. Additionally, error handling is simplified by returning a single error instead of a map of errors, making the tool more user-friendly and robust.What
BenchSpy, including threshold validation, nil report validation, and better readability for infinite metric change. This makes the tool more reliable and easier to use.CompareDirectWithThresholdsfunction to return a singleerrorinstead ofmap[string][]error, simplifying the error handling process.