-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Support for AWS Secrets Manager for ghsecrets tool #1564
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… message for AWS Secrets Manager
gheorghestrimtu
approved these changes
Jan 16, 2025
skudasov
approved these changes
Jan 16, 2025
Quality Gate passedIssues Measures |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces significant enhancements to the
ghsecrets
tool, including support for managing secrets in AWS Secrets Manager alongside GitHub. Key updates include:AWS Secrets Manager Integration:
testsecrets/
prefix for AWS secrets to ensure consistency and compatibility with GitHub Actions.--shared-with
flag.Command Enhancements:
get
command to retrieve secrets from AWS Secrets Manager.Documentation Updates:
Related PRs:
Below is a summarization created by an LLM (gpt-4-0125-preview). Be mindful of hallucinations and verify accuracy.
Why
The changes expand the functionality of
ghsecrets
tool to support AWS Secrets Manager as a backend for storing secrets, in addition to GitHub. This update also introduces the ability to retrieve secrets from AWS, share secrets with additional AWS IAM principals, and handle AWS SSO sessions. The update aims to makeghsecrets
more versatile and useful for managing secrets in different environments.What
README.md
: Updated documentation to reflect new features and usage instructions for interacting with both GitHub and AWS Secrets Manager.go.mod
andgo.sum
: Added dependencies for AWS SDK to interact with AWS services such as Secrets Manager and STS.main.go
: