Forward SETH_LOG_LEVEL env to remote runner #1565
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tofel
approved these changes
Jan 16, 2025
|
lukaszcl
deleted the
TT-1146-Auto-forward-SETH_LOG_LEVEL-to-remote-runner
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Below is a summarization created by an LLM (gpt-4-0125-preview). Be mindful of hallucinations and verify accuracy.
Why
This pull request introduces a new environment variable
SETH_LOG_LEVELto specify the log level used by Seth, enhancing configurability for logging within the system. Additionally, it ensures this new variable is propagated to the Kubernetes environment, ensuring consistency across different deployment environments.What
EnvSethLogLevel,EnvSethLogLevelDescription, andEnvSethLogLevelExampleto define a new environment variable for Seth's log level, enhancing the configurability for logging.config.EnvSethLogLevelin thelookupsslice to ensure the newSETH_LOG_LEVELenvironment variable is properly propagated to the Kubernetes environment, maintaining consistency and configurability in logging across deployments.