Fix really long log issues in remote runners #801
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tateexon
force-pushed
the
triage-max-log-length-in-remote-runner
branch
from
20d8b16 to
ad597ba
Compare
tateexon
force-pushed
the
triage-max-log-length-in-remote-runner
branch
from
ad597ba to
1baff97
Compare
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #801 +/- ##
==========================================
- Coverage 20.19% 17.72% -2.47%
==========================================
Files 27 32 +5
Lines 3462 4198 +736
==========================================
+ Hits 699 744 +45
- Misses 2688 3378 +690
- Partials 75 76 +1 ☔ View full report in Codecov by Sentry. |
tateexon
force-pushed
the
triage-max-log-length-in-remote-runner
branch
from
1baff97 to
913ea99
Compare
tateexon
force-pushed
the
triage-max-log-length-in-remote-runner
branch
from
913ea99 to
b8f361d
Compare
tateexon
had a problem deploying
to
integration
GitHub Actions
Failure
tateexon
force-pushed
the
triage-max-log-length-in-remote-runner
branch
from
b8f361d to
3d4b513
Compare
tateexon
had a problem deploying
to
integration
GitHub Actions
Failure
tateexon
force-pushed
the
triage-max-log-length-in-remote-runner
branch
from
3d4b513 to
3f22399
Compare
tateexon
had a problem deploying
to
integration
GitHub Actions
Failure
tateexon
force-pushed
the
triage-max-log-length-in-remote-runner
branch
from
3f22399 to
b0d289d
Compare
tateexon
had a problem deploying
to
integration
GitHub Actions
Failure
tateexon
force-pushed
the
triage-max-log-length-in-remote-runner
branch
from
af38847 to
fd6dc56
Compare
tateexon
force-pushed
the
triage-max-log-length-in-remote-runner
branch
from
fd6dc56 to
443c971
Compare
tateexon
force-pushed
the
triage-max-log-length-in-remote-runner
branch
from
443c971 to
8beebb0
Compare
tateexon
force-pushed
the
triage-max-log-length-in-remote-runner
branch
from
8beebb0 to
8e84add
Compare
tateexon
had a problem deploying
to
integration
GitHub Actions
Failure
|
SonarQube Quality Gate
|
tateexon
changed the title
AnieeG
approved these changes
Dec 13, 2023
kalverra
approved these changes
Dec 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
readStdPipe can now read any size string coming in whereas before it would top out at the default bufio buffer size.
When pushing logs through a test running in k8s to the remote runner we now break them up in chunks of 50,000 since going much larger can cause issues with kubectl and also github actions runners.