Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix appending of grafana base url #824

Merged
merged 1 commit into from
Jan 22, 2024
Merged

fix appending of grafana base url #824

merged 1 commit into from
Jan 22, 2024

Conversation

Tofel
Copy link
Contributor

@Tofel Tofel commented Jan 22, 2024

🤦‍♂️

@cl-sonarqube-production
Copy link

SonarQube Quality Gate

Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@codecov-commenter
Copy link

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (349d480) 16.89% compared to head (52a0b4c) 16.89%.

Files Patch % Lines
logstream/logstream_handlers.go 0.00% 1 Missing ⚠️
Additional details and impacted files 
@@           Coverage Diff           @@
##             main     #824   +/-   ##
=======================================
  Coverage   16.89%   16.89%           
=======================================
  Files          36       36           
  Lines        4380     4379    -1     
=======================================
  Hits          740      740           
+ Misses       3561     3560    -1     
  Partials       79       79

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Tofel Tofel marked this pull request as ready for review January 22, 2024 20:57
@Tofel Tofel requested review from sebawo and a team as code owners January 22, 2024 20:57
@Tofel Tofel merged commit 587c16c into main Jan 22, 2024
16 checks passed
@Tofel Tofel deleted the f_fix_grafana_url branch January 22, 2024 21:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AnieeG AnieeG AnieeG approved these changes

@kalverra kalverra kalverra approved these changes

@sebawo sebawo Awaiting requested review from sebawo sebawo is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Tofel @codecov-commenter @kalverra @AnieeG