TT-916 Add _secret suffix to secrets in toml #835
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lukaszcl
changed the title
lukaszcl
force-pushed
the
TT-916-Make-TOML-in-CTF-compatible-with-Mercury
branch
from
6b645fb to
e2ba1eb
Compare
lukaszcl
had a problem deploying
to
integration
GitHub Actions
Failure
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #835 +/- ##
==========================================
- Coverage 16.83% 16.70% -0.14%
==========================================
Files 36 36
Lines 4395 4395
==========================================
- Hits 740 734 -6
- Misses 3576 3581 +5
- Partials 79 80 +1 ☔ View full report in Codecov by Sentry. |
2 tasks
lukaszcl
had a problem deploying
to
integration
GitHub Actions
Failure
lukaszcl
had a problem deploying
to
integration
GitHub Actions
Failure
|
lukaszcl
had a problem deploying
to
integration
GitHub Actions
Failure
lukaszcl
had a problem deploying
to
integration
GitHub Actions
Failure
lukaszcl
had a problem deploying
to
integration
GitHub Actions
Failure
AnieeG
pushed a commit
to smartcontractkit/ccip
that referenced
this pull request
Feb 29, 2024
## Motivation This adds `_secret` suffix to some TOML keys for E2E tests. ## Solution This is to make the TOML configs compatible with next CTF version smartcontractkit/chainlink-testing-framework#835 ## TODO - [x] Confirm with @AnieeG - [x] Remove [a08d3e0](a08d3e0) commit before merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mercury keeps secrets directly in TOML configs and uses a masking script to hide them on Github CI.
In order to reuse TOML object from CTF like GrafanaConfig we need to add _secret suffix to all keys that should be masked on Github.