Update pre-commit

[tateexon]

• Break apart different pre-commit checks
• Fix lint so it only runs once
• Add Adam's checks for eth keys, rpc urls, and local replaces
• Change unit test check to only run before push and not on pre-commit
• Fixed some shell check issues so when people make changes to those files in the future they only have to deal with their changes and not pre-existing issues.

---

Below is a summarization created by an LLM (gpt-4-0125-preview). Be mindful of hallucinations and verify accuracy.

Why

The changes introduce additional pre-commit hooks for Ethereum keys, RPC URLs, Go mod local replaces, linting Go files, and a pre-push hook for running unit tests. They aim to enhance code quality and security by automating checks for sensitive keys, invalid URLs, local module replacements, and linting issues. Additionally, updating the golangci-lint version and adding shellcheck directives in shell scripts improve the development environment's consistency and compliance with best practices.

What

• .githooks/RPC-URLs-pre-commit
  • Added a new pre-commit hook script to check for RPC URLs in the codebase.
• .githooks/ethereum-keys-pre-commit
  • Added a new pre-commit hook script to check for Ethereum keys in the codebase.
• .githooks/go-mod-local-replace-pre-commit
  • Added a new pre-commit hook script to check for local replacements in go.mod files.
• .githooks/lint-go-pre-commit
  • Added a new pre-commit hook script for linting Go files.
• .githooks/pre-push
  • Removed the existing pre-push hook script.
• .githooks/unit-test-pre-push
  • Added a new pre-push hook script for running unit tests.
• .pre-commit-config.yaml
  • Updated the pre-commit configuration to include the new pre-commit hooks for Ethereum keys, RPC URLs, Go mod local replaces, and linting Go files.
  • Removed the golangci-lint hook and replaced it with custom hooks.
  • Added a new pre-push hook for running unit tests.
• .tool-versions
  • Updated golangci-lint from version 1.57.1 to 1.57.2.
• charts/besu-prysm/install.sh and charts/geth-prysm/install.sh
  • Added shellcheck directives to disable specific warnings.
• charts/besu-prysm/uninstall.sh and charts/geth-prysm/uninstall.sh
  • Added shellcheck directives and made minor adjustments for clarity and compliance.
• grafana/client.go
  • Refactored variable names for consistency and added a comment to suppress a linter warning.
• k8s-test-runner/package.sh
  • Added a safety check for changing directories and clarified the tar command.
• k8s/scripts/buildBaseImage, k8s/scripts/buildImageHelper, k8s/scripts/buildTestImage, k8s/scripts/entrypoint
  • Added shellcheck directives in scripts and made minor adjustments for better clarity and compliance with best practices.

[kalverra]

Don't have to deal with it now, but I don't think these are necessary. It seems like pre-commit doesn't bother to show any output unless you exit with a non-zero code (even then I've found that to be oddly funky)

[tateexon]

Good call out, makes the scripts a bit more clean if we get rid of these.

[cl-sonarqube-production]

Quality Gate passed

Issues
0 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarQube