Fixes to foundry connections and configs #924
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AnieeG
changed the title
|
kalverra
reviewed
Apr 24, 2024
| @@ -149,14 +149,8 @@ func (n *NetworkConfig) Validate() error { | |||
| return fmt.Errorf("chain ID for %s network must be set", name) | |||
| } | |||
| } | |||
| if n.ForkConfigs != nil { | |||
| if _, ok := n.ForkConfigs[network]; ok { | |||
There was a problem hiding this comment.
Why remove these checks?
There was a problem hiding this comment.
While using Anvil you may choose not to fork a network, and start network from empty state like geth. Hence these checks are not required
kalverra
approved these changes
Apr 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Anvil can be run without forking. Renamed network's
ForkConfigtoAnvilConfig. Made necessary changes to make fork config not mandatory while using Anvil.Below is a summarization created by an LLM (gpt-4-0125-preview). Be mindful of hallucinations and verify accuracy.
Why
The changes improve the function signatures in
foundry.goby switching from value to pointer receivers for thePropsparameter. This enhances memory efficiency and consistency in how thePropsstruct is handled across functions.What
Newfunction signature to accept a pointer toPropsinstead of a value. This change optimizes memory usage by passing a reference.NewVersionedfunction signature to also accept a pointer toPropsfor the same reasons of efficiency and consistency with theNewfunction adjustments.