Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TT-1099] bump k8s geth to 1.12.2 #925

Merged
merged 3 commits into from
Apr 25, 2024
Merged

[TT-1099] bump k8s geth to 1.12.2 #925

merged 3 commits into from
Apr 25, 2024

Conversation

Tofel
Copy link
Contributor

@Tofel Tofel commented Apr 25, 2024

It's not eth2, but more modern than what we have now


Below is a summarization created by an LLM (gpt-4-0125-preview). Be mindful of hallucinations and verify accuracy.

Why

The updates ensure that the Ethereum (geth) Helm chart and deployment configurations are aligned with the latest geth version (v1.12.2), enhancing features, security, and compatibility. It also optimizes the geth deployment by modifying command line arguments to include a broader set of APIs for HTTP and WebSocket interfaces, improving developer experience and application integration capabilities.

What

  • charts/geth/Chart.yaml
    • Updated version from 0.4.3 to 0.4.4 and appVersion from 1.10.25 to 1.12.2. This bumps the chart version and aligns the app version with the latest geth.
  • charts/geth/templates/geth-deployment.yml
    • Removed --unlock arguments for three accounts to streamline the deployment configuration.
    • Added --http.api and --ws.api arguments with values admin,debug,web3,eth,txpool,personal,clique,miner,net to extend the API support over HTTP and WebSocket.
    • Removed miner settings (--miner.threads, --miner.gasprice, --miner.gastarget, --miner.gaslimit) and replaced with --dev.gaslimit to align with development network preferences.
  • charts/geth/values.yaml
    • Updated geth.image.version from v1.10.25 to v1.12.2 to use the latest geth version in the Helm chart values.
  • k8s/pkg/helm/ethereum/geth.go
    • Changed the default geth image version from v1.10.25 to v1.12.2 in the Go code to ensure the Kubernetes package uses the updated geth version.

@Tofel Tofel marked this pull request as ready for review April 25, 2024 12:41
@Tofel Tofel requested review from sebawo and a team as code owners April 25, 2024 12:41
@cl-sonarqube-production
Copy link

@Tofel Tofel merged commit 5dbacb3 into main Apr 25, 2024
18 of 20 checks passed
@Tofel Tofel deleted the tt_1099_k8s_geth_1_12 branch April 25, 2024 16:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants