[TT-922] Universal concurrent executor #927
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AnieeG
reviewed
Apr 25, 2024
kalverra
requested changes
Apr 25, 2024
AnieeG
approved these changes
Apr 26, 2024
…arent context in concurrent executor
…chainlink-testing-framework into tt_922_automation_seth
|
kalverra
approved these changes
Apr 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I found myself repeating the same patter in
chainlinkrepo, when migrating Automation tests that require concurrent deployment with Seth and decides to abstract it away and add to CTF for reuse.Below is a summarization created by an LLM (gpt-4-0125-preview). Be mindful of hallucinations and verify accuracy.
Why
The changes improve the concurrency utilities by introducing a new
ConcurrentExecutorclass that handles tasks in parallel, enhancing error handling and task distribution. The addition oftxpool, debug, tracemodules tonethermind_eth2.goextends the JSON-RPC capabilities of the Nethermind client. Adjustments inreorg.goaim to standardize constants related to Ethereum Geth nodes, potentially simplifying configuration or deployment logic. The introduction of aDivideSliceutility function inslice.gofacilitates more efficient division of workloads for concurrent processing.What
concurrency/example.gointroduces a new file demonstrating the deployment of contracts with configurable and identical settings in a concurrent manner.concurrency/executor.goadds a newConcurrentExecutorclass to manage concurrent task execution with improved error handling and task distribution logic.concurrency/executor_test.goprovides tests for theConcurrentExecutorclass, ensuring functionality such as fail-fast behavior and task execution with varying concurrency levels.docker/test_env/nethermind_eth2.goupdates the--JsonRpc.EnabledModulesparameter to includetxpool, debug, tracemodules, enhancing the JSON-RPC functionalities of the Nethermind Ethereum client.k8s/pkg/helm/reorg/reorg.godefines new constants (URLsKey,TXNodesAppLabel,MinerNodesAppLabel) likely for more standardized handling or identification of Ethereum Geth nodes in Kubernetes deployments.utils/slice/slice.gointroduces a utility functionDivideSlicefor evenly dividing a slice into a specified number of parts, useful for distributing tasks among workers in concurrent operations.