-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[TT-1136, CCIP-2255] make eth node log level configurable via TOML #943
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AnieeG
approved these changes
May 8, 2024
AnieeG
approved these changes
May 8, 2024
Quality Gate passedIssues Measures |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Below is a summarization created by an LLM (gpt-4-0125-preview). Be mindful of hallucinations and verify accuracy.
Why
The changes introduce the ability to set and validate node log levels for Ethereum networks within the testing framework, ensuring greater control and flexibility over logging during tests. They also integrate log level configuration into various Ethereum client containers, allowing for dynamic adjustment of verbosity in blockchain simulations.
What
config/private_ethereum_network.go
strings
package import for string manipulation.DefaultNodeLogLevel
variable to define a default log level.NodeLogLevel
field toEthereumNetworkConfig
struct to allow configuration of node log level.Validate
method to ensureNodeLogLevel
is set to a default value if not specified and to validate log level strings.config/tomls/default_ethereum_env.toml
node_log_level
configuration with a default value of "info".docker/test_env/besu_eth1.go & besu_eth2.go
LogLevel
field from the environment configuration.docker/test_env/env_component.go
LogLevel
field toEnvComponent
struct to store log level configuration.WithLogLevel
function to configure log level for environment components.docker/test_env/erigon_eth1.go & erigon_eth2.go
docker/test_env/ethereum_env.go
docker/test_env/ethereum_env_test.go
docker/test_env/geth_base.go
logLevelToVerbosity
method to convert log level strings to Geth verbosity levels.docker/test_env/geth_eth2.go
docker/test_env/nethermind_eth1.go & nethermind_eth2.go
LogLevel
field.utils/templates/geth.go