Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TT-1140] Universal log processor + modified log verifier #947

Merged
merged 3 commits into from
May 10, 2024

Conversation

Tofel
Copy link
Contributor

@Tofel Tofel commented May 9, 2024

Why?

So that we can use CL node log verification that was added for k8s also in docker!


Below is a summarization created by an LLM (gpt-4-0125-preview). Be mindful of hallucinations and verify accuracy.

Why

The changes in this pull request are aimed at enhancing the logging and log processing capabilities of the system. By introducing a new log processor, refining the log scanning and verification process, and enabling more granular control over log messages, these changes strive to improve the system's ability to analyze and manage log data more effectively.

What

  • logstream/logprocessor.go
    • Added a new file introducing LogProcessor struct and methods for processing container logs and creating a processor for regex matching. This allows for more sophisticated log processing based on the content of the logs.
  • logstream/logstream.go
    • Added a new method GetLogLocation to retrieve log locations, enhancing the system's capacity to manage and reference log files.
  • testreporters/reporter_model.go
    • Modified WriteTeardownLogs to utilize a new method FindAllLogFilesToScan with an additional parameter, allowing for more precise log file scanning.
    • Introduced FindAllLogFilesToScan as a replacement for findAllLogFilesToScan, now accepting a partialFilename parameter to filter log files more effectively.
    • Replaced allowedLogMessage with AllowedLogMessage struct and added a new function NewAllowedLogMessage, providing a more flexible way to define and handle allowed log messages.
    • Changed verifyLogFile to VerifyLogFile and added parameters for failure threshold and allowed messages, offering a more customizable approach to log verification.

@Tofel Tofel temporarily deployed to integration May 9, 2024 14:42 — with GitHub Actions Inactive
@Tofel Tofel temporarily deployed to integration May 9, 2024 14:42 — with GitHub Actions Inactive
@Tofel Tofel temporarily deployed to integration May 9, 2024 14:46 — with GitHub Actions Inactive
@Tofel Tofel temporarily deployed to integration May 9, 2024 15:06 — with GitHub Actions Inactive
@Tofel Tofel temporarily deployed to integration May 9, 2024 15:06 — with GitHub Actions Inactive
@Tofel Tofel temporarily deployed to integration May 9, 2024 15:10 — with GitHub Actions Inactive
@cl-sonarqube-production
Copy link

@Tofel Tofel marked this pull request as ready for review May 10, 2024 06:56
@Tofel Tofel requested review from sebawo and a team as code owners May 10, 2024 06:56
@Tofel Tofel merged commit 5de277d into main May 10, 2024
23 of 24 checks passed
@Tofel Tofel deleted the tt_1140_log_scanner branch May 10, 2024 06:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants