-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[TT-1151] use latest stable version of evm node implementations #954
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…gas estimation for zero address if evm node is not geth
kalverra
requested changes
May 17, 2024
Co-authored-by: Adam Hamrick <[email protected]>
kalverra
approved these changes
May 17, 2024
Quality Gate passedIssues Measures |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Below is a summarization created by an LLM (gpt-4-0125-preview). Be mindful of hallucinations and verify accuracy.
Why
The changes focus on updating Ethereum client versions to their latest or more stable releases for multiple clients such as Besu, Erigon, Geth, and Nethermind within a test environment setup. Additionally, there's an enhancement in how gas estimations are handled and a minor correction in a test case to improve clarity and testing accuracy.
What
docker/test_env/besu_base.go
defaultBesuEth2Image
to"hyperledger/besu:24.5.1"
. This change ensures the use of the latest Besu version for Ethereum 2.0 simulations, likely bringing in performance improvements and bug fixes.networkConfig.SimulationType = "Besu"
to clearly indicate the Ethereum client type in simulations, enhancing debuggability and logging.docker/test_env/besu_test.go
TestBesuEth2
from"Could connect to the evm client"
to"Could connect Besu"
, and added a new line at the end of the file. These changes improve the error message's clarity when connections to the Besu client fail during tests.docker/test_env/erigon_base.go
defaultErigonEth2Image
to"thorax/erigon:v2.59.3"
. This change updates the Erigon container to a more stable version for Ethereum 2.0 simulations, addressing specific issues like broken gas estimations.networkConfig.SimulationType = "Erigon"
to mark the simulation type explicitly, aiding in identifying the Ethereum client in use during tests.docker/test_env/geth_base.go
defaultGethEth2Image
to"ethereum/client-go:v1.14.3"
. This update moves the Geth client to a newer version for Ethereum 2.0 simulations, likely incorporating new features and fixes.networkConfig.SimulationType = "Geth"
to label the type of Ethereum client being simulated, improving the ability to filter logs and debug issues.docker/test_env/nethermind_base.go
defaultNethermindEth2Image
to"nethermind/nethermind:1.26.0"
. This update ensures the use of an updated Nethermind version for Ethereum 2.0 simulations, reflecting the latest improvements and bug resolutions.networkConfig.SimulationType = "Nethermind"
to specifically denote the client type in network simulations, facilitating easier identification during testing phases.docker/test_env/test_utils.go
sendAndCompareBalances
function to includeFrom
address andValue
inethereum.CallMsg
for gas estimations, and reorganized the code for clarity. This adjustment ensures more accurate gas estimations by considering the transaction's value and sender, leading to more reliable test outcomes.