Skip to content

fix: race conditions due to share variables #54132

fix: race conditions due to share variables

fix: race conditions due to share variables #54132

Triggered via push February 19, 2024 22:33
Status Success
Total duration 4m 48s
Artifacts

solidity.yml

on: push
Detect changes
7s
Detect changes
Prepublish Test
1m 22s
Prepublish Test
Native Compilation
4m 22s
Native Compilation
Solidity Lint
37s
Solidity Lint
Prettier Formatting
48s
Prettier Formatting
Fit to window
Zoom out
Zoom in

Annotations

1 error and 21 warnings
Solidity Lint
Got error Error: No job for job name: "Lint" found during self-lookup, invalid job name given? Available jobs names + ids: Detect changes|21746101301,Prepublish Test|21746106957,Solidity Lint|21746107097,Native Compilation|21746107221,Prettier Formatting|21746107354 , failing action
Solidity Lint: contracts/test/v0.8/Cron.test.ts#L43
'libType' is never reassigned. Use 'const' instead
Solidity Lint: contracts/test/v0.8/KeeperRegistrar.test.ts#L37
Use "@ts-expect-error" instead of "@ts-ignore", as "@ts-ignore" will do nothing if the following line is error-free
Solidity Lint: contracts/test/v0.8/VRFSubscriptionBalanceMonitor.test.ts#L282
'tx' is never reassigned. Use 'const' instead
Solidity Lint: contracts/test/v0.8/automation/AutomationRegistry2_2.test.ts#L1329
'newConfig' is never reassigned. Use 'const' instead
Solidity Lint: contracts/test/v0.8/automation/AutomationRegistry2_2.test.ts#L1361
'newConfig' is never reassigned. Use 'const' instead
Solidity Lint: contracts/test/v0.8/automation/AutomationRegistry2_2.test.ts#L1462
'newConfig' is never reassigned. Use 'const' instead
Solidity Lint: contracts/test/v0.8/automation/AutomationRegistry2_2.test.ts#L2894
'checkUpkeepResult' is never reassigned. Use 'const' instead
Solidity Lint: contracts/test/v0.8/automation/ERC20BalanceMonitor.test.ts#L276
'tx' is never reassigned. Use 'const' instead
Solidity Lint: contracts/test/v0.8/automation/EthBalanceMonitor.test.ts#L267
'tx' is never reassigned. Use 'const' instead
Solidity Lint: contracts/test/v0.8/automation/KeeperRegistrar2_0.test.ts#L40
Use "@ts-expect-error" instead of "@ts-ignore", as "@ts-ignore" will do nothing if the following line is error-free
Solidity Lint
Fallback should be external and payable to accept native currency
Solidity Lint
Constant variable c_feedParamKey is not in all caps, it should be C_FEEDPARAMKEY
Solidity Lint
Explicitly mark visibility of state
Solidity Lint
Constant variable c_timeParamKey is not in all caps, it should be C_TIMEPARAMKEY
Solidity Lint
Explicitly mark visibility of state
Solidity Lint
Constant variable scale is not in all caps, it should be SCALE
Solidity Lint
Explicitly mark visibility of state
Solidity Lint
Internal function getReport is not prefixed with underscore (_)
Solidity Lint
Internal function bytes32ToHexString is not prefixed with underscore (_)
Solidity Lint
Internal function updateFeed is not prefixed with underscore (_)
Native Compilation
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/cache@v3. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.