Capability registry internal review (#13368)

* update gas measurements

* verify node not part of DON when removing

* update gas snapshots

* update uint declaration

* Update gethwrappers

* add extra test for removing ndoes

* remove unnecessary sets

* add changeset

* revert gas snapshot

* Revert "update gas measurements"

This reverts commit ac688de.

* update snapshots

* undo forge std changes

* add function to update capabilities

* allow adding multiple capabilities at once

* allow deprecating multiple capabilities at once

* address PR feedback

* update comment

* update comment

* verify node operator valid when adding node and update node operator

* I03: index nodeOperatorId in events

* fix conflicts

* I08:  gas optimizations

* return don capability config contract config from capability registry

* generate wrappers

* make don id uint declaration consistent

* increase test coverage

* address PR feedback

* remove update capabilities

* I9:  nitpicks

* I12:  nits and stylings

* add comments

* I10: Gas optimizations

* generate wrappers

* add changesets

* add capability registry comment explaining why we do not validate node operator name

* address PR feedback

* regen wrappers

* add changesets

---------

Co-authored-by: app-token-issuer-infra-releng[bot] <120227048+app-token-issuer-infra-releng[bot]@users.noreply.github.com>

.changeset/cuddly-lions-sneeze.md

@@ -0,0 +1,5 @@
+---
+"chainlink": patch
+---
+
+#internal remove update capabilities from capability registry

.changeset/empty-dryers-fold.md

@@ -0,0 +1,5 @@
+---
+"chainlink": patch
+---
+
+#internal capability registry informational findings

.changeset/empty-tools-run.md

@@ -0,0 +1,5 @@
+---
+"chainlink": patch
+---
+
+#internal return don capability config contract config from capability registry

.changeset/famous-timers-love.md

@@ -0,0 +1,5 @@
+---
+"chainlink": patch
+---
+
+#internal add capability registry comment explaining why we do not validate node operator name

.changeset/itchy-jars-return.md

@@ -0,0 +1,5 @@
+---
+"chainlink": patch
+---
+
+#internal verify valid node operator when adding nodes to capability registry

.changeset/short-seals-love.md

@@ -0,0 +1,5 @@
+---
+"chainlink": patch
+---
+
+#internal verify that node is not part of a DON when removing

.changeset/smooth-parents-reply.md

@@ -0,0 +1,5 @@
+---
+"chainlink": patch
+---
+
+#internal remove tracking deprecated arrays

.changeset/soft-schools-beam.md

@@ -0,0 +1,5 @@
+---
+"chainlink": patch
+---
+
+#internal capability registry internal review

.changeset/stale-mayflies-own.md

@@ -0,0 +1,5 @@
+---
+"chainlink": patch
+---
+
+#internal internal-review-fixes-for-capability-registry

.changeset/twelve-buckets-retire.md

@@ -0,0 +1,5 @@
+---
+"chainlink": patch
+---
+
+#internal allow updating capabilities and to add/remove multiple capabilities at once from the capability registry

.changeset/wet-ligers-complain.md

@@ -0,0 +1,5 @@
+---
+"chainlink": patch
+---
+
+#internal update uint256 to uint32 for donId declaration in capability config interface

contracts/.changeset/blue-onions-sleep.md

@@ -0,0 +1,5 @@
+---
+'@chainlink/contracts': patch
+---
+
+capability registry internal review

contracts/.changeset/chilly-rivers-study.md

@@ -0,0 +1,5 @@
+---
+'@chainlink/contracts': patch
+---
+
+add capability registry comment explaining why we do not validate node operator name

contracts/.changeset/dull-phones-retire.md

@@ -0,0 +1,5 @@
+---
+'@chainlink/contracts': patch
+---
+
+capability registry informational findings

contracts/.changeset/happy-plants-dance.md

@@ -0,0 +1,5 @@
+---
+'@chainlink/contracts': patch
+---
+
+allow updating capabilities and to add/remove multiple capabilities at once from the capability registry

contracts/.changeset/healthy-impalas-hammer.md

@@ -0,0 +1,5 @@
+---
+'@chainlink/contracts': patch
+---
+
+remove tracking deprecated arrays

contracts/.changeset/ninety-wolves-sleep.md

@@ -0,0 +1,5 @@
+---
+'@chainlink/contracts': patch
+---
+
+#internal internal-review-for-capability-registry

contracts/.changeset/orange-tips-attend.md

@@ -0,0 +1,5 @@
+---
+'@chainlink/contracts': patch
+---
+
+validate that a node is not part of a DON when removing

contracts/.changeset/silent-ravens-lay.md

@@ -0,0 +1,5 @@
+---
+'@chainlink/contracts': patch
+---
+
+remove update capabilities from capability registry

contracts/.changeset/stupid-lamps-sell.md

@@ -0,0 +1,5 @@
+---
+'@chainlink/contracts': patch
+---
+
+verify valid node operator when adding nodes to capability registry

contracts/.changeset/sweet-geese-rescue.md

@@ -0,0 +1,5 @@
+---
+'@chainlink/contracts': patch
+---
+
+update uint256 to uint32 for donId declaration in capability config interface

contracts/.changeset/yellow-snails-wash.md

@@ -0,0 +1,5 @@
+---
+'@chainlink/contracts': patch
+---
+
+return don capability config contract config from capability registry

contracts/gas-snapshots/keystone.gas-snapshot

@@ -1,76 +1,83 @@
-CapabilityRegistry_AddCapabilityTest:test_AddCapability_NoConfigurationContract() (gas: 146839)
-CapabilityRegistry_AddCapabilityTest:test_AddCapability_WithConfiguration() (gas: 171105)
-CapabilityRegistry_AddCapabilityTest:test_DeprecatesCapability() (gas: 88694)
-CapabilityRegistry_AddCapabilityTest:test_EmitsEvent() (gas: 88815)
-CapabilityRegistry_AddCapabilityTest:test_RevertWhen_CalledByNonAdmin() (gas: 21728)
-CapabilityRegistry_AddCapabilityTest:test_RevertWhen_CalledByNonAdmin() (gas: 22199)
-CapabilityRegistry_AddCapabilityTest:test_RevertWhen_CapabilityDoesNotExist() (gas: 15521)
-CapabilityRegistry_AddCapabilityTest:test_RevertWhen_CapabilityExists() (gas: 138685)
-CapabilityRegistry_AddCapabilityTest:test_RevertWhen_CapabilityIsDeprecated() (gas: 89496)
-CapabilityRegistry_AddCapabilityTest:test_RevertWhen_ConfigurationContractDoesNotMatchInterface() (gas: 3998052)
-CapabilityRegistry_AddCapabilityTest:test_RevertWhen_ConfigurationContractNotDeployed() (gas: 24995)
-CapabilityRegistry_AddDONTest:test_AddDON() (gas: 332870)
-CapabilityRegistry_AddDONTest:test_RevertWhen_CalledByNonAdmin() (gas: 19285)
-CapabilityRegistry_AddDONTest:test_RevertWhen_CapabilityDoesNotExist() (gas: 155460)
-CapabilityRegistry_AddDONTest:test_RevertWhen_DeprecatedCapabilityAdded() (gas: 224960)
-CapabilityRegistry_AddDONTest:test_RevertWhen_DuplicateCapabilityAdded() (gas: 239487)
-CapabilityRegistry_AddDONTest:test_RevertWhen_DuplicateNodeAdded() (gas: 108051)
-CapabilityRegistry_AddDONTest:test_RevertWhen_FaultToleranceIsZero() (gas: 40158)
-CapabilityRegistry_AddDONTest:test_RevertWhen_NodeDoesNotSupportCapability() (gas: 169921)
-CapabilityRegistry_AddNodeOperatorsTest:test_AddNodeOperators() (gas: 133916)
-CapabilityRegistry_AddNodeOperatorsTest:test_RevertWhen_CalledByNonAdmin() (gas: 16949)
-CapabilityRegistry_AddNodeOperatorsTest:test_RevertWhen_NodeOperatorAdminAddressZero() (gas: 17795)
-CapabilityRegistry_AddNodesTest:test_AddsNodeInfo() (gas: 355866)
-CapabilityRegistry_AddNodesTest:test_OwnerCanAddNodes() (gas: 355854)
-CapabilityRegistry_AddNodesTest:test_RevertWhen_AddingDuplicateP2PId() (gas: 301701)
-CapabilityRegistry_AddNodesTest:test_RevertWhen_AddingNodeWithInvalidCapability() (gas: 55370)
-CapabilityRegistry_AddNodesTest:test_RevertWhen_AddingNodeWithoutCapabilities() (gas: 27706)
-CapabilityRegistry_AddNodesTest:test_RevertWhen_CalledByNonNodeOperatorAdminAndNonOwner() (gas: 24579)
-CapabilityRegistry_AddNodesTest:test_RevertWhen_P2PIDEmpty() (gas: 27412)
-CapabilityRegistry_AddNodesTest:test_RevertWhen_SignerAddressEmpty() (gas: 27051)
-CapabilityRegistry_AddNodesTest:test_RevertWhen_SignerAddressNotUnique() (gas: 310108)
-CapabilityRegistry_GetCapabilitiesTest:test_ExcludesDeprecatedCapabilities() (gas: 115054)
-CapabilityRegistry_GetCapabilitiesTest:test_ReturnsCapabilities() (gas: 53946)
-CapabilityRegistry_GetDONsTest:test_CorrectlyFetchesDONs() (gas: 71958)
-CapabilityRegistry_GetDONsTest:test_DoesNotIncludeRemovedDONs() (gas: 116197)
-CapabilityRegistry_GetHashedCapabilityTest:test_CorrectlyGeneratesHashedCapabilityId() (gas: 10842)
-CapabilityRegistry_GetHashedCapabilityTest:test_DoesNotCauseIncorrectClashes() (gas: 11915)
-CapabilityRegistry_GetNodeOperatorsTest:test_CorrectlyFetchesNodeOperators() (gas: 34361)
-CapabilityRegistry_GetNodeOperatorsTest:test_DoesNotIncludeRemovedNodeOperators() (gas: 99004)
-CapabilityRegistry_GetNodesTest:test_CorrectlyFetchesNodes() (gas: 59970)
-CapabilityRegistry_GetNodesTest:test_DoesNotIncludeRemovedNodes() (gas: 73816)
-CapabilityRegistry_RemoveDONsTest:test_RemovesDON() (gas: 99887)
+CapabilityRegistry_AddCapabilitiesTest:test_AddCapability_NoConfigurationContract() (gas: 152088)
+CapabilityRegistry_AddCapabilitiesTest:test_AddCapability_WithConfiguration() (gas: 176069)
+CapabilityRegistry_AddCapabilitiesTest:test_RevertWhen_CalledByNonAdmin() (gas: 24678)
+CapabilityRegistry_AddCapabilitiesTest:test_RevertWhen_CapabilityExists() (gas: 145679)
+CapabilityRegistry_AddCapabilitiesTest:test_RevertWhen_ConfigurationContractDoesNotMatchInterface() (gas: 94561)
+CapabilityRegistry_AddCapabilitiesTest:test_RevertWhen_ConfigurationContractNotDeployed() (gas: 92916)
+CapabilityRegistry_AddDONTest:test_AddDON() (gas: 499044)
+CapabilityRegistry_AddDONTest:test_RevertWhen_CalledByNonAdmin() (gas: 19249)
+CapabilityRegistry_AddDONTest:test_RevertWhen_CapabilityDoesNotExist() (gas: 291958)
+CapabilityRegistry_AddDONTest:test_RevertWhen_DeprecatedCapabilityAdded() (gas: 365106)
+CapabilityRegistry_AddDONTest:test_RevertWhen_DuplicateCapabilityAdded() (gas: 375985)
+CapabilityRegistry_AddDONTest:test_RevertWhen_DuplicateNodeAdded() (gas: 177974)
+CapabilityRegistry_AddDONTest:test_RevertWhen_FaultToleranceIsZero() (gas: 43337)
+CapabilityRegistry_AddDONTest:test_RevertWhen_NodeDoesNotSupportCapability() (gas: 306419)
+CapabilityRegistry_AddNodeOperatorsTest:test_AddNodeOperators() (gas: 184267)
+CapabilityRegistry_AddNodeOperatorsTest:test_RevertWhen_CalledByNonAdmin() (gas: 17624)
+CapabilityRegistry_AddNodeOperatorsTest:test_RevertWhen_NodeOperatorAdminAddressZero() (gas: 18520)
+CapabilityRegistry_AddNodesTest:test_AddsNodeInfo() (gas: 355458)
+CapabilityRegistry_AddNodesTest:test_OwnerCanAddNodes() (gas: 355446)
+CapabilityRegistry_AddNodesTest:test_RevertWhen_AddingDuplicateP2PId() (gas: 301431)
+CapabilityRegistry_AddNodesTest:test_RevertWhen_AddingNodeWithInvalidCapability() (gas: 55243)
+CapabilityRegistry_AddNodesTest:test_RevertWhen_AddingNodeWithInvalidNodeOperator() (gas: 24962)
+CapabilityRegistry_AddNodesTest:test_RevertWhen_AddingNodeWithoutCapabilities() (gas: 27738)
+CapabilityRegistry_AddNodesTest:test_RevertWhen_CalledByNonNodeOperatorAdminAndNonOwner() (gas: 25130)
+CapabilityRegistry_AddNodesTest:test_RevertWhen_P2PIDEmpty() (gas: 27444)
+CapabilityRegistry_AddNodesTest:test_RevertWhen_SignerAddressEmpty() (gas: 27083)
+CapabilityRegistry_AddNodesTest:test_RevertWhen_SignerAddressNotUnique() (gas: 309850)
+CapabilityRegistry_DeprecateCapabilitiesTest:test_DeprecatesCapability() (gas: 92873)
+CapabilityRegistry_DeprecateCapabilitiesTest:test_EmitsEvent() (gas: 93001)
+CapabilityRegistry_DeprecateCapabilitiesTest:test_RevertWhen_CalledByNonAdmin() (gas: 22879)
+CapabilityRegistry_DeprecateCapabilitiesTest:test_RevertWhen_CapabilityDoesNotExist() (gas: 16166)
+CapabilityRegistry_DeprecateCapabilitiesTest:test_RevertWhen_CapabilityIsDeprecated() (gas: 94265)
+CapabilityRegistry_GetCapabilitiesTest:test_ExcludesDeprecatedCapabilities() (gas: 119306)
+CapabilityRegistry_GetCapabilitiesTest:test_ReturnsCapabilities() (gas: 54034)
+CapabilityRegistry_GetDONsTest:test_CorrectlyFetchesDONs() (gas: 65704)
+CapabilityRegistry_GetDONsTest:test_DoesNotIncludeRemovedDONs() (gas: 88473)
+CapabilityRegistry_GetHashedCapabilityTest:test_CorrectlyGeneratesHashedCapabilityId() (gas: 11428)
+CapabilityRegistry_GetHashedCapabilityTest:test_DoesNotCauseIncorrectClashes() (gas: 13087)
+CapabilityRegistry_GetNodeOperatorsTest:test_CorrectlyFetchesNodeOperators() (gas: 36675)
+CapabilityRegistry_GetNodeOperatorsTest:test_DoesNotIncludeRemovedNodeOperators() (gas: 38982)
+CapabilityRegistry_GetNodesTest:test_CorrectlyFetchesNodes() (gas: 59880)
+CapabilityRegistry_GetNodesTest:test_DoesNotIncludeRemovedNodes() (gas: 71576)
+CapabilityRegistry_RemoveDONsTest:test_RemovesDON() (gas: 60696)
 CapabilityRegistry_RemoveDONsTest:test_RevertWhen_CalledByNonAdmin() (gas: 15669)
-CapabilityRegistry_RemoveDONsTest:test_RevertWhen_DONDoesNotExist() (gas: 14160)
-CapabilityRegistry_RemoveNodeOperatorsTest:test_RemovesNodeOperator() (gas: 141779)
-CapabilityRegistry_RemoveNodeOperatorsTest:test_RevertWhen_CalledByNonOwner() (gas: 15761)
-CapabilityRegistry_RemoveNodesTest:test_CanAddNodeWithSameSignerAddressAfterRemoving() (gas: 80895)
-CapabilityRegistry_RemoveNodesTest:test_OwnerCanRemoveNodes() (gas: 57865)
-CapabilityRegistry_RemoveNodesTest:test_RemovesNode() (gas: 57864)
-CapabilityRegistry_RemoveNodesTest:test_RevertWhen_CalledByNonNodeOperatorAdminAndNonOwner() (gas: 25085)
-CapabilityRegistry_RemoveNodesTest:test_RevertWhen_NodeDoesNotExist() (gas: 18395)
+CapabilityRegistry_RemoveDONsTest:test_RevertWhen_DONDoesNotExist() (gas: 16540)
+CapabilityRegistry_RemoveNodeOperatorsTest:test_RemovesNodeOperator() (gas: 36069)
+CapabilityRegistry_RemoveNodeOperatorsTest:test_RevertWhen_CalledByNonOwner() (gas: 15838)
+CapabilityRegistry_RemoveNodesTest:test_CanAddNodeWithSameSignerAddressAfterRemoving() (gas: 114067)
+CapabilityRegistry_RemoveNodesTest:test_CanRemoveWhenDONDeleted() (gas: 371521)
+CapabilityRegistry_RemoveNodesTest:test_CanRemoveWhenNodeNoLongerPartOfDON() (gas: 712537)
+CapabilityRegistry_RemoveNodesTest:test_OwnerCanRemoveNodes() (gas: 72324)
+CapabilityRegistry_RemoveNodesTest:test_RemovesNode() (gas: 74158)
+CapabilityRegistry_RemoveNodesTest:test_RevertWhen_CalledByNonNodeOperatorAdminAndNonOwner() (gas: 24871)
+CapabilityRegistry_RemoveNodesTest:test_RevertWhen_NodeDoesNotExist() (gas: 18373)
+CapabilityRegistry_RemoveNodesTest:test_RevertWhen_NodePartOfDON() (gas: 385126)
 CapabilityRegistry_RemoveNodesTest:test_RevertWhen_P2PIDEmpty() (gas: 18385)
-CapabilityRegistry_UpdateDONTest:test_RevertWhen_CalledByNonAdmin() (gas: 19370)
-CapabilityRegistry_UpdateDONTest:test_RevertWhen_CapabilityDoesNotExist() (gas: 133496)
-CapabilityRegistry_UpdateDONTest:test_RevertWhen_DONDoesNotExist() (gas: 17790)
-CapabilityRegistry_UpdateDONTest:test_RevertWhen_DeprecatedCapabilityAdded() (gas: 202996)
-CapabilityRegistry_UpdateDONTest:test_RevertWhen_DuplicateCapabilityAdded() (gas: 217569)
-CapabilityRegistry_UpdateDONTest:test_RevertWhen_DuplicateNodeAdded() (gas: 86089)
-CapabilityRegistry_UpdateDONTest:test_RevertWhen_NodeDoesNotSupportCapability() (gas: 148002)
-CapabilityRegistry_UpdateDONTest:test_UpdatesDON() (gas: 330869)
-CapabilityRegistry_UpdateNodeOperatorTest:test_RevertWhen_CalledByNonAdminAndNonOwner() (gas: 17712)
-CapabilityRegistry_UpdateNodeOperatorTest:test_RevertWhen_NodeOperatorAdminIsZeroAddress() (gas: 17636)
-CapabilityRegistry_UpdateNodeOperatorTest:test_UpdatesNodeOperator() (gas: 72345)
-CapabilityRegistry_UpdateNodesTest:test_CanUpdateParamsIfNodeSignerAddressNoLongerUsed() (gas: 252301)
-CapabilityRegistry_UpdateNodesTest:test_OwnerCanUpdateNodes() (gas: 159616)
-CapabilityRegistry_UpdateNodesTest:test_RevertWhen_AddingNodeWithInvalidCapability() (gas: 36253)
-CapabilityRegistry_UpdateNodesTest:test_RevertWhen_CalledByNonNodeOperatorAdminAndNonOwner() (gas: 24580)
-CapabilityRegistry_UpdateNodesTest:test_RevertWhen_NodeDoesNotExist() (gas: 27344)
-CapabilityRegistry_UpdateNodesTest:test_RevertWhen_NodeSignerAlreadyAssignedToAnotherNode() (gas: 29312)
-CapabilityRegistry_UpdateNodesTest:test_RevertWhen_P2PIDEmpty() (gas: 27332)
-CapabilityRegistry_UpdateNodesTest:test_RevertWhen_SignerAddressEmpty() (gas: 27015)
-CapabilityRegistry_UpdateNodesTest:test_RevertWhen_UpdatingNodeWithoutCapabilities() (gas: 25666)
-CapabilityRegistry_UpdateNodesTest:test_UpdatesNodeInfo() (gas: 159605)
+CapabilityRegistry_TypeAndVersionTest:test_TypeAndVersion() (gas: 9796)
+CapabilityRegistry_UpdateDONTest:test_RevertWhen_CalledByNonAdmin() (gas: 19406)
+CapabilityRegistry_UpdateDONTest:test_RevertWhen_CapabilityDoesNotExist() (gas: 157904)
+CapabilityRegistry_UpdateDONTest:test_RevertWhen_DONDoesNotExist() (gas: 17826)
+CapabilityRegistry_UpdateDONTest:test_RevertWhen_DeprecatedCapabilityAdded() (gas: 231052)
+CapabilityRegistry_UpdateDONTest:test_RevertWhen_DuplicateCapabilityAdded() (gas: 241977)
+CapabilityRegistry_UpdateDONTest:test_RevertWhen_DuplicateNodeAdded() (gas: 103722)
+CapabilityRegistry_UpdateDONTest:test_RevertWhen_NodeDoesNotSupportCapability() (gas: 172410)
+CapabilityRegistry_UpdateDONTest:test_UpdatesDON() (gas: 433638)
+CapabilityRegistry_UpdateNodeOperatorTest:test_RevertWhen_CalledByNonAdminAndNonOwner() (gas: 20583)
+CapabilityRegistry_UpdateNodeOperatorTest:test_RevertWhen_NodeOperatorAdminIsZeroAddress() (gas: 20004)
+CapabilityRegistry_UpdateNodeOperatorTest:test_RevertWhen_NodeOperatorDoesNotExist() (gas: 19742)
+CapabilityRegistry_UpdateNodeOperatorTest:test_RevertWhen_NodeOperatorIdAndParamLengthsMismatch() (gas: 15382)
+CapabilityRegistry_UpdateNodeOperatorTest:test_UpdatesNodeOperator() (gas: 36903)
+CapabilityRegistry_UpdateNodesTest:test_CanUpdateParamsIfNodeSignerAddressNoLongerUsed() (gas: 250725)
+CapabilityRegistry_UpdateNodesTest:test_OwnerCanUpdateNodes() (gas: 158858)
+CapabilityRegistry_UpdateNodesTest:test_RevertWhen_AddingNodeWithInvalidCapability() (gas: 35985)
+CapabilityRegistry_UpdateNodesTest:test_RevertWhen_CalledByNonNodeOperatorAdminAndNonOwner() (gas: 25086)
+CapabilityRegistry_UpdateNodesTest:test_RevertWhen_NodeDoesNotExist() (gas: 27325)
+CapabilityRegistry_UpdateNodesTest:test_RevertWhen_NodeSignerAlreadyAssignedToAnotherNode() (gas: 29206)
+CapabilityRegistry_UpdateNodesTest:test_RevertWhen_P2PIDEmpty() (gas: 27313)
+CapabilityRegistry_UpdateNodesTest:test_RevertWhen_SignerAddressEmpty() (gas: 26996)
+CapabilityRegistry_UpdateNodesTest:test_RevertWhen_UpdatingNodeWithoutCapabilities() (gas: 25560)
+CapabilityRegistry_UpdateNodesTest:test_UpdatesNodeInfo() (gas: 158847)
 KeystoneForwarder_ReportTest:test_Report_ConfigVersion() (gas: 2676465)
 KeystoneForwarder_ReportTest:test_Report_SuccessfulDelivery() (gas: 150738)
 KeystoneForwarder_ReportTest:test_RevertWhen_AlreadyProcessed() (gas: 158024)