Skip to content

Commit

Permalink
address comments
Browse files Browse the repository at this point in the history
  • Loading branch information
poopoothegorilla committed Mar 21, 2024
1 parent cadfca3 commit 384baad
Showing 1 changed file with 4 additions and 5 deletions.
9 changes: 4 additions & 5 deletions core/chains/evm/txmgr/evm_inmemory_store_test.go
Original file line number Diff line number Diff line change
@@ -1,7 +1,6 @@
package txmgr_test

import (
"context"
"math/big"
"testing"

Expand All @@ -28,7 +27,7 @@ func TestInMemoryStore_UpdateTxForRebroadcast(t *testing.T) {
t.Run("delete all receipts for transaction", func(t *testing.T) {
db := pgtest.NewSqlxDB(t)
_, dbcfg, evmcfg := evmtxmgr.MakeTestConfigs(t)
persistentStore := cltest.NewTestTxStore(t, db, dbcfg)
persistentStore := cltest.NewTestTxStore(t, db)
kst := cltest.NewKeyStore(t, db, dbcfg)
_, fromAddress := cltest.MustInsertRandomKey(t, kst.Eth())

Expand All @@ -55,7 +54,7 @@ func TestInMemoryStore_UpdateTxForRebroadcast(t *testing.T) {
err = inMemoryStore.UpdateTxForRebroadcast(ctx, inTx, txAttempt)
require.NoError(t, err)

expTx, err := persistentStore.FindTxWithAttempts(inTx.ID)
expTx, err := persistentStore.FindTxWithAttempts(ctx, inTx.ID)
require.NoError(t, err)

fn := func(tx *evmtxmgr.Tx) bool { return true }
Expand All @@ -72,14 +71,14 @@ func TestInMemoryStore_UpdateTxForRebroadcast(t *testing.T) {
t.Run("error parity for in-memory vs persistent store", func(t *testing.T) {
db := pgtest.NewSqlxDB(t)
_, dbcfg, evmcfg := evmtxmgr.MakeTestConfigs(t)
persistentStore := cltest.NewTestTxStore(t, db, dbcfg)
persistentStore := cltest.NewTestTxStore(t, db)
kst := cltest.NewKeyStore(t, db, dbcfg)
_, fromAddress := cltest.MustInsertRandomKey(t, kst.Eth())

ethClient := evmtest.NewEthClientMockWithDefaultChain(t)
lggr := logger.TestSugared(t)
chainID := ethClient.ConfiguredChainID()
ctx := context.Background()
ctx := testutils.Context(t)

inMemoryStore, err := commontxmgr.NewInMemoryStore[
*big.Int,
Expand Down

0 comments on commit 384baad

Please sign in to comment.