Add ARG MODE to plugins/chainlink.Dockerfile to enable Beholder in de…

…v/test (#14560)

* Add ARG MODE to plugins/chainlink.Dockerfile to enable Beholder in dev/test

* Adjusting make scripts to accept build tags with TAG var

* Testing out new build args

---------

Co-authored-by: Sergei Drugalev <[email protected]>
Co-authored-by: Damjan Smickovski <[email protected]>

.github/actions/build-chainlink-image/action.yml

@@ -22,6 +22,9 @@ inputs:
     description: "Check if the image exists in ECR before building"
     required: false
     default: 'false'
+  build_args:
+    required: false
+    description: Additional build arguments for the image
 
 runs:
   using: composite
@@ -37,7 +40,7 @@ runs:
         AWS_ROLE_TO_ASSUME: ${{ inputs.AWS_ROLE_TO_ASSUME }}
     - name: Build Image
       if: steps.check-image.outputs.exists != 'true'
-      uses: smartcontractkit/.github/actions/ctf-build-image@1a26fe378d7ebdc34ab1fe31ec4a6d1c376199f8 # [email protected]
+      uses: smartcontractkit/.github/actions/ctf-build-image@f1078918a926c0a75eeebbad8ffc3f98b8502ba9 # [email protected]
       with:
         cl_repo: smartcontractkit/chainlink
         cl_ref: ${{ inputs.git_commit_sha }}
@@ -47,6 +50,7 @@ runs:
         QA_AWS_ROLE_TO_ASSUME: ${{ inputs.AWS_ROLE_TO_ASSUME }}
         GO_COVER_FLAG: true
         dep_evm_sha: ${{ inputs.dep_evm_sha }}
+        build_args: ${{ inputs.build_args }}
     - name: Print Chainlink Image Built
       shell: sh
       run: |

.github/workflows/integration-tests.yml

@@ -199,6 +199,8 @@ jobs:
           AWS_REGION: ${{ secrets.QA_AWS_REGION }}
           AWS_ROLE_TO_ASSUME: ${{ secrets.QA_AWS_ROLE_TO_ASSUME }}
           dep_evm_sha: ${{ inputs.evm-ref }}
+          build_args: |
+            TAGS=dev
 
   run-core-e2e-tests-for-pr:
     name: Run Core E2E Tests For PR

GNUmakefile

@@ -38,23 +38,27 @@ docs: ## Install and run pkgsite to view Go docs
 
 .PHONY: install-chainlink
 install-chainlink: operator-ui ## Install the chainlink binary.
-	go install $(GOFLAGS) .
+	go install $(GOFLAGS) $(if $(TAGS),-tags $(TAGS)) .
+
+.PHONY: install-chainlink-dev
+install-chainlink-dev: operator-ui ## Install a dev build of the chainlink binary.
+	$(MAKE) install-chainlink TAGS="dev $(TAGS)"
 
 .PHONY: install-chainlink-cover
 install-chainlink-cover: operator-ui ## Install the chainlink binary with cover flag.
 	go install -cover $(GOFLAGS) .
 
 .PHONY: chainlink
 chainlink: ## Build the chainlink binary.
-	go build $(GOFLAGS) .
+	go build $(GOFLAGS) $(if $(TAGS),-tags $(TAGS)) .
 
 .PHONY: chainlink-dev
 chainlink-dev: ## Build a dev build of chainlink binary.
-	go build -tags dev $(GOFLAGS) .
+	$(MAKE) chainlink TAGS="dev $(TAGS)"
 
 .PHONY: chainlink-test
 chainlink-test: ## Build a test build of chainlink binary.
-	go build $(GOFLAGS) .
+	$(MAKE) chainlink
 
 .PHONY: install-medianpoc
 install-medianpoc: ## Build & install the chainlink-medianpoc binary.

plugins/chainlink.Dockerfile

@@ -9,15 +9,16 @@ COPY tools/bin/ldflags ./tools/bin/
 ADD go.mod go.sum ./
 RUN go mod download
 
-# Env vars needed for chainlink build
+# Chainlink build args
 ARG COMMIT_SHA
+ARG TAGS
 
 COPY . .
 
 RUN apt-get update && apt-get install -y jq
 
-# Build the golang binaries
-RUN make install-chainlink
+# Build the golang binaries (use dev mode if specified)
+RUN bash -c "make install-chainlink TAGS=\"$TAGS\""
 
 # Install medianpoc binary
 RUN make install-medianpoc