Merge branch 'develop' into BCI-2702-Apply-LimitMultiplier-to-gas-lim…

…it-in-all-gas-estimators

.changeset/odd-mugs-end.md

@@ -0,0 +1,5 @@
+---
+"chainlink": patch
+---
+
+address TODOs and docs for 2.3

.changeset/young-deers-itch.md

@@ -0,0 +1,5 @@
+---
+"chainlink": minor
+---
+
+pay deactivated transmitters in offchain settlement

.github/workflows/build-publish-develop.yml

@@ -62,7 +62,7 @@ jobs:
         uses: smartcontractkit/.github/actions/setup-gap@1bc7ce34fa81fffcb4a6eb0e4e12e59d94d0fc8f # [email protected]
         with:
           aws-region: ${{ secrets.AWS_REGION }}
-          aws-role-arn: ${{ secrets.AWS_OIDC_IAM_ROLE_ARN }}
+          aws-role-arn: ${{ secrets.AWS_OIDC_CRIB_ROLE_ARN_SAND }}
           api-gateway-host: ${{ secrets.AWS_API_GW_HOST_K8S_SAND }}
           use-k8s: "true"
           k8s-cluster-name: ${{ secrets.AWS_EKS_CLUSTER_NAME_SAND }}

.golangci.yml

@@ -105,7 +105,7 @@ linters-settings:
             desc: Use gopkg.in/guregu/null.v4 instead
           - pkg: gopkg.in/guregu/null.v3
             desc: Use gopkg.in/guregu/null.v4 instead
-          - pkg: https://github.com/go-gorm/gorm
+          - pkg: github.com/go-gorm/gorm
             desc: Use github.com/jmoiron/sqlx directly instead
 issues:
   exclude-rules:

CODEOWNERS

@@ -85,6 +85,8 @@ core/scripts/gateway @smartcontractkit/functions
 
 # At the end, match any files missed by the patterns above
 /contracts/scripts/native_solc_compile_all_events_mock @smartcontractkit/functions
+# Remove changeset files from the codeowners
+/contracts/.changeset
 
 
 # Tests

contracts/.changeset/fast-maps-rush.md

@@ -0,0 +1,5 @@
+---
+"@chainlink/contracts": minor
+---
+
+pay deactivated transmitters in offchain settlement

contracts/.changeset/odd-experts-jump.md

@@ -0,0 +1,5 @@
+---
+"@chainlink/contracts": patch
+---
+
+address TODOs and docs for 2.3

contracts/.changeset/weak-kangaroos-heal.md

@@ -0,0 +1,5 @@
+---
+"@chainlink/contracts": patch
+---
+
+bump solhint and address issues, remove unused imports

contracts/.solhint.json

@@ -11,6 +11,8 @@
 		"no-inline-assembly": "off",
 		"contract-name-camelcase": "off",
 		"no-unused-import": "error",
+		"gas-struct-packing": "warn",
+		"interface-starts-with-i": "warn",
 		"func-visibility": [
 			"error",
 			{

contracts/STYLE_GUIDE.md

@@ -64,8 +64,6 @@ uint256 networkFeeUSDCents; // good
 
 ### Structs
 
-- All structs should be packed to have the lowest memory footprint to reduce gas usage. Even structs that will never be written to storage should be packed.
-  - A contract can be considered a struct; it should also be packed to reduce gas cost.
 - Structs should contain struct packing comments to clearly indicate the storage slot layout
   - Using the exact characters from the example below will ensure visually appealing struct packing comments.
   - Notice there is no line on the unpacked last `fee` item.
@@ -378,17 +376,22 @@ function getNum() external view returns (uint64 num) {
 
 Use [custom errors](https://blog.soliditylang.org/2021/04/21/custom-errors/) instead of emitting strings. This saves contract code size and simultaneously provides more informative error messages.
 
-rule: `custom-errors`
+rule: `gas-custom-errors`
 
 ## Interfaces
 
 Interfaces should be named `IFoo` instead of `FooInterface`. This follows the patterns of popular [libraries like OpenZeppelin’s](https://github.com/OpenZeppelin/openzeppelin-contracts/blob/master/contracts/token/ERC20/IERC20.sol#L9). 
 
-rule: `tbd`
+rule: `interface-starts-with-i`
 
 ## Structs
 
-Structs should be constructed with named arguments. This prevents accidental assignment to the wrong field and makes the code more readable.
+- All structs should be packed to have the lowest memory footprint to reduce gas usage. Even structs that will never be written to storage should be packed.
+  - A contract can be considered a struct; it should also be packed to reduce gas cost.
+
+rule: `gas-struct-packing`
+
+- Structs should be constructed with named arguments. This prevents accidental assignment to the wrong field and makes the code more readable.
 
 ```solidity
 // Good

contracts/package.json

@@ -18,7 +18,7 @@
     "prepublishOnly": "pnpm compile && ./scripts/prepublish_generate_abi_folder",
     "publish-beta": "pnpm publish --tag beta",
     "publish-prod": "npm dist-tag add @chainlink/[email protected] latest",
-    "solhint": "solhint --max-warnings 20 \"./src/v0.8/**/*.sol\""
+    "solhint": "solhint --max-warnings 85 \"./src/v0.8/**/*.sol\""
   },
   "files": [
     "src/v0.8",
@@ -37,13 +37,11 @@
     "@ethersproject/bignumber": "~5.7.0",
     "@ethersproject/contracts": "~5.7.0",
     "@ethersproject/providers": "~5.7.2",
-    "@ethersproject/random": "~5.7.0",
     "@nomicfoundation/hardhat-network-helpers": "^1.0.9",
     "@nomiclabs/hardhat-ethers": "^2.2.3",
     "@nomiclabs/hardhat-etherscan": "^3.1.7",
     "@nomiclabs/hardhat-waffle": "2.0.6",
     "@openzeppelin/hardhat-upgrades": "1.28.0",
-    "@openzeppelin/test-helpers": "^0.5.16",
     "@typechain/ethers-v5": "^7.2.0",
     "@typechain/hardhat": "^7.0.0",
     "@types/cbor": "5.0.1",
@@ -74,14 +72,13 @@
     "prettier": "^3.2.5",
     "prettier-plugin-solidity": "1.3.1",
     "rlp": "^2.2.7",
-    "solhint": "^4.1.1",
+    "solhint": "^4.5.2",
     "solhint-plugin-chainlink-solidity": "git+https://github.com/smartcontractkit/chainlink-solhint-rules.git#v1.2.1",
     "solhint-plugin-prettier": "^0.1.0",
     "solidity-coverage": "^0.8.5",
     "ts-node": "^10.9.2",
-    "tslib": "^2.6.2",
     "typechain": "^8.2.1",
-    "typescript": "^5.3.3"
+    "typescript": "^5.4.3"
   },
   "dependencies": {
     "@eth-optimism/contracts": "0.6.0",