golangci-lint: enable gocritic (#14995)

* golangci-lint: enable gocritic

* auto-fix gocritic

.golangci.yml

@@ -10,6 +10,7 @@ linters:
     - exportloopref
     - fatcontext
     - ginkgolinter
+    - gocritic
     - goimports
     - gosec
     - loggercheck

common/client/node_selector_highest_head_test.go

@@ -109,7 +109,7 @@ func TestHighestHeadNodeSelectorWithOrder(t *testing.T) {
 			nodes = append(nodes, node)
 		}
 		selector := newNodeSelector(NodeSelectionModeHighestHead, nodes)
-		//Should select the first node because all things are equal
+		// Should select the first node because all things are equal
 		assert.Same(t, nodes[0], selector.Select())
 	})
 
@@ -128,7 +128,7 @@ func TestHighestHeadNodeSelectorWithOrder(t *testing.T) {
 
 		nodes := []Node[types.ID, nodeClient]{node1, node2, node3}
 		selector := newNodeSelector(NodeSelectionModeHighestHead, nodes)
-		//Should select the second node as it has the highest priority
+		// Should select the second node as it has the highest priority
 		assert.Same(t, nodes[1], selector.Select())
 	})
 
@@ -147,7 +147,7 @@ func TestHighestHeadNodeSelectorWithOrder(t *testing.T) {
 
 		nodes := []Node[types.ID, nodeClient]{node1, node2, node3}
 		selector := newNodeSelector(NodeSelectionModeHighestHead, nodes)
-		//Should select the third node as it has the highest head
+		// Should select the third node as it has the highest head
 		assert.Same(t, nodes[2], selector.Select())
 	})
 
@@ -170,7 +170,7 @@ func TestHighestHeadNodeSelectorWithOrder(t *testing.T) {
 
 		nodes := []Node[types.ID, nodeClient]{node1, node2, node3, node4}
 		selector := newNodeSelector(NodeSelectionModeHighestHead, nodes)
-		//Should select the third node as it has the highest head and will win the priority tie-breaker
+		// Should select the third node as it has the highest head and will win the priority tie-breaker
 		assert.Same(t, nodes[2], selector.Select())
 	})
 }

common/client/node_selector_total_difficulty.go

@@ -41,7 +41,7 @@ func (s totalDifficultyNodeSelector[CHAIN_ID, RPC]) Select() Node[CHAIN_ID, RPC]
 		}
 	}
 
-	//If all nodes have td == nil pick one from the nodes that are alive
+	// If all nodes have td == nil pick one from the nodes that are alive
 	if len(nodes) == 0 {
 		return firstOrHighestPriority(aliveNodes)
 	}

common/client/node_selector_total_difficulty_test.go

@@ -111,7 +111,7 @@ func TestTotalDifficultyNodeSelectorWithOrder(t *testing.T) {
 			nodes = append(nodes, node)
 		}
 		selector := newNodeSelector(NodeSelectionModeTotalDifficulty, nodes)
-		//Should select the first node because all things are equal
+		// Should select the first node because all things are equal
 		assert.Same(t, nodes[0], selector.Select())
 	})
 
@@ -130,7 +130,7 @@ func TestTotalDifficultyNodeSelectorWithOrder(t *testing.T) {
 
 		nodes := []Node[types.ID, nodeClient]{node1, node2, node3}
 		selector := newNodeSelector(NodeSelectionModeTotalDifficulty, nodes)
-		//Should select the second node as it has the highest priority
+		// Should select the second node as it has the highest priority
 		assert.Same(t, nodes[1], selector.Select())
 	})
 
@@ -149,7 +149,7 @@ func TestTotalDifficultyNodeSelectorWithOrder(t *testing.T) {
 
 		nodes := []Node[types.ID, nodeClient]{node1, node2, node3}
 		selector := newNodeSelector(NodeSelectionModeTotalDifficulty, nodes)
-		//Should select the third node as it has the highest td
+		// Should select the third node as it has the highest td
 		assert.Same(t, nodes[2], selector.Select())
 	})
 
@@ -172,7 +172,7 @@ func TestTotalDifficultyNodeSelectorWithOrder(t *testing.T) {
 
 		nodes := []Node[types.ID, nodeClient]{node1, node2, node3, node4}
 		selector := newNodeSelector(NodeSelectionModeTotalDifficulty, nodes)
-		//Should select the third node as it has the highest td and will win the priority tie-breaker
+		// Should select the third node as it has the highest td and will win the priority tie-breaker
 		assert.Same(t, nodes[2], selector.Select())
 	})
 }

common/txmgr/confirmer.go

@@ -1077,7 +1077,7 @@ func (ec *Confirmer[CHAIN_ID, HEAD, ADDR, TX_HASH, BLOCK_HASH, R, SEQ, FEE]) Ens
 		"chainLength", head.ChainLength(),
 	}
 
-	//Here, we rely on the finalized block provided in the chain instead of the one
+	// Here, we rely on the finalized block provided in the chain instead of the one
 	//provided via a dedicated method to avoid the false warning of the chain being
 	//too short. When `FinalityTagBypass = true,` HeadTracker tracks `finality depth
 	//+ history depth` to prevent excessive CPU usage. Thus, the provided chain may

core/capabilities/ccip/ccip_integration_tests/home_chain_test.go

@@ -35,7 +35,7 @@ func TestHomeChainReader_ChainConfigs(t *testing.T) {
 	p2pIDs := integrationhelpers.P2pIDsFromInts(arr)
 	uni.AddCapability(p2pIDs)
 
-	//==============================Apply configs to Capability Contract=================================
+	// ==============================Apply configs to Capability Contract=================================
 	encodedChainConfig, err := chainconfig.EncodeChainConfig(chainconfig.ChainConfig{
 		GasPriceDeviationPPB:    cciptypes.NewBigIntFromInt64(1000),
 		DAGasPriceDeviationPPB:  cciptypes.NewBigIntFromInt64(1_000_000),
@@ -62,7 +62,7 @@ func TestHomeChainReader_ChainConfigs(t *testing.T) {
 
 	t.Logf("homchain reader is ready")
 
-	//================================Test HomeChain Reader===============================
+	// ================================Test HomeChain Reader===============================
 	expectedChainConfigs := map[cciptypes.ChainSelector]ccipreader.ChainConfig{}
 	for _, c := range inputConfig {
 		expectedChainConfigs[cciptypes.ChainSelector(c.ChainSelector)] = ccipreader.ChainConfig{

core/capabilities/ccip/ccip_integration_tests/rmn/rmn_home_test.go

@@ -39,7 +39,7 @@ func TestRMNHomeReader_GetRMNNodesInfo(t *testing.T) {
 		observerBitmap2 = 1
 	)
 
-	//================================Deploy and configure RMNHome===============================
+	// ================================Deploy and configure RMNHome===============================
 	rmnHomeAddress, _, rmnHome, err := rmn_home.DeployRMNHome(uni.Transactor, uni.Backend)
 	require.NoError(t, err)
 	uni.Backend.Commit()
@@ -83,7 +83,7 @@ func TestRMNHomeReader_GetRMNNodesInfo(t *testing.T) {
 		require.NoError(t, err1)
 	})
 
-	//================================Test RMNHome Reader===============================
+	// ================================Test RMNHome Reader===============================
 	expectedNodesInfo := integrationhelpers.GenerateExpectedRMNHomeNodesInfo(staticConfig, chainID1)
 
 	require.Eventually(

core/capabilities/ccip/types/mocks/home_chain_reader.go

@@ -20,47 +20,47 @@ type HomeChainReader struct {
 }
 
 func (_m *HomeChainReader) GetChainConfig(chainSelector cciptypes.ChainSelector) (ccipreaderpkg.ChainConfig, error) {
-	//TODO implement me
+	// TODO implement me
 	panic("implement me")
 }
 
 func (_m *HomeChainReader) GetAllChainConfigs() (map[cciptypes.ChainSelector]ccipreaderpkg.ChainConfig, error) {
-	//TODO implement me
+	// TODO implement me
 	panic("implement me")
 }
 
 func (_m *HomeChainReader) GetSupportedChainsForPeer(id types.PeerID) (mapset.Set[cciptypes.ChainSelector], error) {
-	//TODO implement me
+	// TODO implement me
 	panic("implement me")
 }
 
 func (_m *HomeChainReader) GetKnownCCIPChains() (mapset.Set[cciptypes.ChainSelector], error) {
-	//TODO implement me
+	// TODO implement me
 	panic("implement me")
 }
 
 func (_m *HomeChainReader) GetFChain() (map[cciptypes.ChainSelector]int, error) {
-	//TODO implement me
+	// TODO implement me
 	panic("implement me")
 }
 
 func (_m *HomeChainReader) Start(ctx context.Context) error {
-	//TODO implement me
+	// TODO implement me
 	panic("implement me")
 }
 
 func (_m *HomeChainReader) Close() error {
-	//TODO implement me
+	// TODO implement me
 	panic("implement me")
 }
 
 func (_m *HomeChainReader) HealthReport() map[string]error {
-	//TODO implement me
+	// TODO implement me
 	panic("implement me")
 }
 
 func (_m *HomeChainReader) Name() string {
-	//TODO implement me
+	// TODO implement me
 	panic("implement me")
 }
 

core/capabilities/integration_tests/framework/peer.go

@@ -172,7 +172,7 @@ func NewPeerID() string {
 
 	peerID := append(libp2pMagic(), privKey[:]...)
 
-	return base58.Encode(peerID[:])
+	return base58.Encode(peerID)
 }
 
 func libp2pMagic() []byte {

core/capabilities/remote/target/endtoend_test.go

@@ -436,7 +436,7 @@ func NewPeerID() string {
 
 	peerID := append(libp2pMagic(), privKey[:]...)
 
-	return base58.Encode(peerID[:])
+	return base58.Encode(peerID)
 }
 
 func libp2pMagic() []byte {

core/capabilities/remote/target/request/server_request_test.go

@@ -276,7 +276,7 @@ func NewPeerID() string {
 
 	peerID := append(libp2pMagic(), privKey[:]...)
 
-	return base58.Encode(peerID[:])
+	return base58.Encode(peerID)
 }
 
 func libp2pMagic() []byte {

core/chains/chain_kv_test.go

@@ -44,13 +44,13 @@ func Test_ChainKV(t *testing.T) {
 	assert.NoError(t, err)
 	assert.Len(t, cs, 1)
 
-	//List explicit chain
+	// List explicit chain
 	cs, err = kv.List(testChainID)
 	assert.NoError(t, err)
 	assert.Len(t, cs, 1)
 	assert.Equal(t, testChain, cs[0])
 
-	//List no such id
+	// List no such id
 	cs, err = kv.List("no such id")
 	assert.Error(t, err)
 	assert.Len(t, cs, 0)

core/chains/evm/abi/selector_parser.go

@@ -112,7 +112,7 @@ func parseCompositeType(unescapedSelector string) ([]abi.ArgumentMarshaling, str
 		// if we're at a delimiter the parameter is unnamed
 		if !(rest[0] == ',' || rest[0] == ')') {
 			// attempt to parse name
-			name, rest, err = parseIdentifier(rest[:])
+			name, rest, err = parseIdentifier(rest)
 			if err != nil {
 				return nil, "", fmt.Errorf("failed to parse name: %v", err)
 			}

core/chains/evm/client/chain_client.go

@@ -461,7 +461,7 @@ func (c *chainClient) TransactionReceipt(ctx context.Context, txHash common.Hash
 	if err != nil {
 		return receipt, err
 	}
-	//return rpc.TransactionReceipt(ctx, txHash)
+	// return rpc.TransactionReceipt(ctx, txHash)
 	return r.TransactionReceiptGeth(ctx, txHash)
 }
 

core/chains/evm/client/simulated_backend_client.go

@@ -483,7 +483,7 @@ func (c *SimulatedBackendClient) BatchCallContext(ctx context.Context, b []rpc.B
 	case <-ctx.Done():
 		return errors.New("context canceled")
 	default:
-		//do nothing
+		// do nothing
 	}
 
 	for i, elem := range b {

core/chains/evm/config/chain_scoped_ocr2_test.go

@@ -9,6 +9,6 @@ import (
 )
 
 func Test_ocr2Config(t *testing.T) {
-	cfg := testutils.NewTestChainScopedConfig(t, nil) //fallback.toml values
+	cfg := testutils.NewTestChainScopedConfig(t, nil) // fallback.toml values
 	require.Equal(t, uint32(5400000), cfg.EVM().OCR2().Automation().GasLimit())
 }

core/chains/evm/config/chain_scoped_ocr_test.go

@@ -10,7 +10,7 @@ import (
 )
 
 func Test_ocrConfig(t *testing.T) {
-	cfg := testutils.NewTestChainScopedConfig(t, nil) //fallback.toml values
+	cfg := testutils.NewTestChainScopedConfig(t, nil) // fallback.toml values
 
 	require.Equal(t, uint16(4), cfg.EVM().OCR().ContractConfirmations())
 	require.Equal(t, mustParseDuration(t, "10s"), cfg.EVM().OCR().ContractTransmitterTransmitTimeout())

core/chains/evm/headtracker/head_saver_test.go

@@ -149,7 +149,7 @@ func TestHeadSaver_Load(t *testing.T) {
 	// verify latest head loaded from db
 	verifyLatestHead(latestHead)
 
-	//verify latest head loaded from memory store
+	// verify latest head loaded from memory store
 	latestHead = saver.LatestChain()
 	require.NotNil(t, latestHead)
 	verifyLatestHead(latestHead)