Skip to content

Commit

Permalink
updated comments in tests
Browse files Browse the repository at this point in the history
  • Loading branch information
silaslenihan committed May 23, 2024
1 parent 635ee51 commit 58afd44
Show file tree
Hide file tree
Showing 3 changed files with 6 additions and 6 deletions.
2 changes: 1 addition & 1 deletion core/services/ocr2/plugins/llo/integration_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -148,7 +148,7 @@ func TestIntegration_LLO(t *testing.T) {
})
}

// Bury everything with finality depth
// Commit blocks to finality depth to ensure LogPoller has finalized blocks to read from
ch, err := nodes[0].App.GetRelayers().LegacyEVMChains().Get(testutils.SimulatedChainID.String())
require.NoError(t, err)
finalityDepth := ch.Config().EVM().FinalityDepth()
Expand Down
8 changes: 4 additions & 4 deletions core/services/ocr2/plugins/mercury/integration_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -184,15 +184,15 @@ func integration_MercuryV1(t *testing.T) {
bootstrapNode := Node{App: appBootstrap, KeyBundle: bootstrapKb}
logObservers = append(logObservers, observedLogs)

// Bury it with finality depth
// Commit blocks to finality depth to ensure LogPoller has finalized blocks to read from
ch, err := bootstrapNode.App.GetRelayers().LegacyEVMChains().Get(testutils.SimulatedChainID.String())
require.NoError(t, err)
finalityDepth := ch.Config().EVM().FinalityDepth()
for i := 0; i < int(finalityDepth); i++ {
backend.Commit()
}

fromBlock := int(finalityDepth) // cannot use zero, start from block 1
fromBlock := int(finalityDepth) // cannot use zero, start from finality depth

// Set up n oracles
var (
Expand Down Expand Up @@ -540,7 +540,7 @@ func integration_MercuryV2(t *testing.T) {
bootstrapNode := Node{App: appBootstrap, KeyBundle: bootstrapKb}
logObservers = append(logObservers, observedLogs)

// Bury it with finality depth
// Commit blocks to finality depth to ensure LogPoller has finalized blocks to read from
ch, err := bootstrapNode.App.GetRelayers().LegacyEVMChains().Get(testutils.SimulatedChainID.String())
require.NoError(t, err)
finalityDepth := ch.Config().EVM().FinalityDepth()
Expand Down Expand Up @@ -830,7 +830,7 @@ func integration_MercuryV3(t *testing.T) {
bootstrapNode := Node{App: appBootstrap, KeyBundle: bootstrapKb}
logObservers = append(logObservers, observedLogs)

// Bury it with finality depth
// Commit blocks to finality depth to ensure LogPoller has finalized blocks to read from
ch, err := bootstrapNode.App.GetRelayers().LegacyEVMChains().Get(testutils.SimulatedChainID.String())
require.NoError(t, err)
finalityDepth := ch.Config().EVM().FinalityDepth()
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -656,7 +656,7 @@ func setupNodes(t *testing.T, nodeKeys [5]ethkey.KeyV2, registry *iregistry21.IK
appBootstrap, bootstrapTransmitter, bootstrapKb,
}

// Bury it with finality depth
// Commit blocks to finality depth to ensure LogPoller has finalized blocks to read from
ch, err := bootstrapNode.App.GetRelayers().LegacyEVMChains().Get(testutils.SimulatedChainID.String())
require.NoError(t, err)
finalityDepth := ch.Config().EVM().FinalityDepth()
Expand Down

0 comments on commit 58afd44

Please sign in to comment.