Add NOTE for enum duplication and todo to resovle it (#11444)

smartcontractkit · Dec 1, 2023 · 60a328e · 60a328e
1 parent f4a97b2
commit 60a328e
Show file tree

Hide file tree

Showing 3 changed files with 8 additions and 0 deletions.
diff --git a/core/services/ocr2/plugins/ocr2keeper/evmregistry/v21/encoding/interface.go b/core/services/ocr2/plugins/ocr2keeper/evmregistry/v21/encoding/interface.go
@@ -11,6 +11,8 @@ import (
 )
 
 const (
+	// NOTE: This enum should be kept in sync with evmregistry/v21/mercury/upkeep_failure_reasons.go
+	// TODO (AUTO-7928) Remove this duplication
 	// upkeep failure onchain reasons
 	UpkeepFailureReasonNone                    uint8 = 0
 	UpkeepFailureReasonUpkeepCancelled         uint8 = 1
@@ -30,6 +32,8 @@ const (
 	UpkeepFailureReasonSimulationFailed        uint8 = 35
 	UpkeepFailureReasonTxHashReorged           uint8 = 36
 
+	// NOTE: This enum should be kept in sync with evmregistry/v21/mercury/upkeep_states.go
+	// TODO (AUTO-7928) Remove this duplication
 	// pipeline execution error
 	NoPipelineError        uint8 = 0
 	CheckBlockTooOld       uint8 = 1

diff --git a/core/services/ocr2/plugins/ocr2keeper/evmregistry/v21/mercury/upkeep_failure_reasons.go b/core/services/ocr2/plugins/ocr2keeper/evmregistry/v21/mercury/upkeep_failure_reasons.go
@@ -2,6 +2,8 @@ package mercury
 
 type MercuryUpkeepFailureReason uint8
 
+// NOTE: This enum should be kept in sync with evmregistry/v21/encoding/interface.go
+// TODO (AUTO-7928) Remove this duplication
 const (
 	// upkeep failure onchain reasons
 	MercuryUpkeepFailureReasonNone                    MercuryUpkeepFailureReason = 0

diff --git a/core/services/ocr2/plugins/ocr2keeper/evmregistry/v21/mercury/upkeep_states.go b/core/services/ocr2/plugins/ocr2keeper/evmregistry/v21/mercury/upkeep_states.go
@@ -2,6 +2,8 @@ package mercury
 
 type MercuryUpkeepState uint8
 
+// NOTE: This enum should be kept in sync with evmregistry/v21/encoding/interface.go
+// TODO (AUTO-7928) Remove this duplication
 const (
 	NoPipelineError        MercuryUpkeepState = 0
 	RpcFlakyFailure        MercuryUpkeepState = 3