Skip to content

Commit

Permalink
Fixed linting
Browse files Browse the repository at this point in the history
  • Loading branch information
amit-momin committed Dec 16, 2024
1 parent e29572f commit 6eadab5
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 2 deletions.
4 changes: 2 additions & 2 deletions core/chains/evm/config/config_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -223,7 +223,7 @@ func TestChainScopedConfig(t *testing.T) {

t.Run("TXMEnabled", func(t *testing.T) {
t.Run("turn on TXMEnabled by default", func(t *testing.T) {
assert.Equal(t, true, cfg.EVM().TXMEnabled())
assert.True(t, cfg.EVM().TXMEnabled())
})

t.Run("verify TXMEnabled is set correctly", func(t *testing.T) {
Expand All @@ -232,7 +232,7 @@ func TestChainScopedConfig(t *testing.T) {
c.TXMEnabled = ptr(val)
})

assert.Equal(t, false, cfg3.EVM().TXMEnabled())
assert.False(t, cfg3.EVM().TXMEnabled())
})
})
}
Expand Down
1 change: 1 addition & 0 deletions core/chains/legacyevm/chain.go
Original file line number Diff line number Diff line change
Expand Up @@ -247,6 +247,7 @@ func newChain(ctx context.Context, cfg *evmconfig.ChainScoped, nodes []*toml.Nod
// note: gas estimator is started as a part of the txm
var txm txmgr.TxManager
var gasEstimator gas.EvmFeeEstimator
//nolint // ignoring styling issue

Check failure on line 250 in core/chains/legacyevm/chain.go

View workflow job for this annotation

GitHub Actions / lint

directive `//nolint // ignoring styling issue` should mention specific linter such as `//nolint:my-linter` (nolintlint)
if !opts.AppConfig.EVMRPCEnabled() {
txm = &txmgr.NullTxManager{ErrMsg: fmt.Sprintf("Ethereum is disabled for chain %d", chainID)}
} else if !cfg.EVM().TXMEnabled() {
Expand Down

0 comments on commit 6eadab5

Please sign in to comment.